This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Fix empty fragment being created when an access modifier occurs by itself #306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access modifiers were registered as a fragment header, but no parser existed that could parse them by themselves (they could only be parsed if they were followed by
function
,operation
, ornewtype
). This means that if they aren't followed by one of those headers, none of the fragment parsers would succeed, so the default parser would try to create an invalid fragment by skipping over input until it finds the next fragment header. However, the next fragment header was the access modifier itself, so it wouldn't skip any input at all, creating an empty invalid fragment instead and causing this exception:To fix this I added parsers for the access modifiers that can consume just an access modifier by itself before creating an invalid fragment, which makes sure that input is always consumed when a fragment is built.
See #259.