Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise BellState sample to allocate qubits inside the loop instead of resetting them on each iteration, and remove ResetAll from individual Prepare... operations. #1370

Closed
Tracked by #1317
swernli opened this issue Apr 9, 2024 · 3 comments · Fixed by #1447
Labels
bug Something isn't working good first issue Good for newcomers samples

Comments

@swernli
Copy link
Collaborator

swernli commented Apr 9, 2024

The allocation of the qubits in samples/algorithms/BellState.qs:

        // Allocate the two qubits that will be used to create a Bell state.
        use register = Qubit[2];

should be moved to be the first step in the for-loop farther down in the entry point operation. Then the calls to ResetAll in each of the preparation operations in the rest of the sample can be removed.

@swernli swernli added bug Something isn't working good first issue Good for newcomers labels Apr 9, 2024
@saram-aman
Copy link

@swernli can you please assign it to me?

@swernli
Copy link
Collaborator Author

swernli commented Apr 15, 2024

@saram-aman Thanks for your interest! I think usually we don't assign issues externally unless there is ongoing work, so feel free to open a PR. I think your comment on the issue is enough to show other folks you are interested.

@tcNickolas
Copy link
Member

Hi @saram-aman,
Are you still working on this issue? Let us know if you ran into any problems with it!
(Such a simple issue with no activity on it for two weeks after expressing the initial interest still reads as "up for grabs" for an external observer.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers samples
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants