Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better UX and error display for circuits #1318

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Conversation

minestarks
Copy link
Member

This improves the circuit UX and the handling of various known error cases.

Circuit

image

Operation circuit

Screenshot 2024-03-26 151611

Unsupported due to result comparison

Screenshot 2024-03-26 151551

Runtime failure

Screenshot 2024-03-26 152053

Compiler error

Screenshot 2024-03-26 152033

Too much circuit

Screenshot 2024-03-26 152020

Not enough circuit

Screenshot 2024-03-26 151736

npm/ux/circuit.tsx Outdated Show resolved Hide resolved
Copy link

Benchmark for a593da2

Click to view benchmark
Test Base PR %
Array append evaluation 344.7±7.11µs 342.7±9.92µs -0.58%
Array literal evaluation 186.3±1.62µs 178.5±4.91µs -4.19%
Array update evaluation 431.3±5.28µs 424.3±2.47µs -1.62%
Deutsch-Jozsa evaluation 5.1±0.06ms 5.2±0.07ms +1.96%
Large file parity evaluation 33.8±0.07ms 33.5±0.27ms -0.89%
Large input file 28.6±0.31ms 28.6±0.49ms 0.00%
Large nested iteration 33.5±0.20ms 33.5±0.36ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1610.9±63.37µs 1669.7±133.10µs +3.65%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.9±0.09ms 7.7±0.07ms -2.53%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1535.6±58.60µs 1540.1±79.06µs +0.29%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 21.4±0.14ms 21.5±0.16ms +0.47%
Standard library 16.7±0.07ms 16.6±0.13ms -0.60%
Teleport evaluation 83.3±4.52µs 84.0±4.33µs +0.84%

Copy link

Benchmark for d0e4bcb

Click to view benchmark
Test Base PR %
Array append evaluation 341.1±7.05µs 332.8±3.01µs -2.43%
Array literal evaluation 170.2±0.99µs 175.9±3.99µs +3.35%
Array update evaluation 418.7±4.45µs 416.7±10.40µs -0.48%
Deutsch-Jozsa evaluation 5.1±0.06ms 5.1±0.04ms 0.00%
Large file parity evaluation 33.8±0.17ms 33.7±0.42ms -0.30%
Large input file 33.2±1.18ms 29.1±0.85ms -12.35%
Large nested iteration 33.1±1.27ms 32.7±0.44ms -1.21%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1578.0±55.96µs 1591.7±69.99µs +0.87%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.9±0.09ms 7.8±0.08ms -1.27%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1512.8±81.75µs 1503.6±62.40µs -0.61%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 21.1±0.67ms 21.2±0.66ms +0.47%
Standard library 17.0±0.53ms 16.4±0.07ms -3.53%
Teleport evaluation 81.2±4.15µs 83.9±6.74µs +3.33%

@minestarks minestarks added this pull request to the merge queue Mar 27, 2024
Merged via the queue into main with commit 038a613 Mar 27, 2024
16 checks passed
@minestarks minestarks deleted the minestarks/circuits-ux branch March 27, 2024 00:47
@minestarks
Copy link
Member Author

Related #1085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants