Parse manifest in Rust instead of Python #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 9f91728Click to view benchmark
|
Benchmark for 9cebb9aClick to view benchmark
|
Benchmark for c481cc1Click to view benchmark
|
minestarks
requested changes
Apr 1, 2024
There was a problem hiding this comment.
I'm afraid this change will interfere with how the notebook language service works (for which I'm realizing there's no integration tests, so nothing in the CI broke).
# Return the configuration information to provide a hint to the
# language service through the cell output.
return Config(target_profile, language_features)This line is critical for the language service - it causes the qsharp.json configuration to be written out to the notebook cell output, which the language service will read to configure compiler options. (Can give you a demo to show you what I mean, but you can try by changing languageFeatures and re-running qsharp.init to see how the squiggles change in the editor).
I think this requirement forces us to parse the qsharp.json at the Python level. Even if we parse it in Rust, we'd need to return the contents of the manifest back to Python... which will be too convoluted to be worth it IMO.
sezna
reviewed
Apr 2, 2024
orpuente-MS
requested review from
cesarzc,
swernli,
DmitryVasilevsky and
ScottCarda-MS
as code owners
I implemented the solution we talked about. Passing the raw manifest around and parsing it when it gets to rust land. |
Benchmark for b1d25bfClick to view benchmark
|
Benchmark for 0386608Click to view benchmark
|
minestarks
requested changes
Apr 8, 2024
Co-authored-by: Mine Starks <16928427+minestarks@users.noreply.github.com>
Benchmark for 6a1889fClick to view benchmark
|
Benchmark for f7dfd63Click to view benchmark
|
Benchmark for e500567Click to view benchmark
|
I fixed the type mismatch. I will add the integration test to #1313 instead of this PR. This is one is ready for review. |
Benchmark for 43ac472Click to view benchmark
|
sezna
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR regains some rust real-state. It delegates the parsing of the manifest in
pip/qsharp/_qsharp.py/init()to rust, avoiding duplicate manifest-parsing logic in the project.This change is needed to unblock #1313