Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix completion auto-open position in notebook cells #1398

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

minestarks
Copy link
Member

@minestarks minestarks commented Apr 17, 2024

Fix regression in #1310

Bug:

auto-open-broke

Fix:

auto-open-fixed-2

auto-open-fixed-1

Copy link

Benchmark for df96d4f

Click to view benchmark
Test Base PR %
Array append evaluation 346.9±4.22µs 351.3±11.71µs +1.27%
Array literal evaluation 193.2±3.76µs 192.8±0.83µs -0.21%
Array update evaluation 432.7±2.57µs 437.0±10.80µs +0.99%
Core + Standard library compilation 16.9±0.18ms 17.3±0.42ms +2.37%
Deutsch-Jozsa evaluation 5.0±0.06ms 5.0±0.04ms 0.00%
Large file parity evaluation 33.7±0.14ms 33.7±0.37ms 0.00%
Large input file compilation 11.2±0.10ms 11.3±0.25ms +0.89%
Large input file compilation (interpreter) 43.8±0.88ms 44.2±0.95ms +0.91%
Large nested iteration 34.1±0.48ms 34.4±0.58ms +0.88%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1487.2±29.73µs 1495.5±37.95µs +0.56%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.7±0.09ms 7.8±0.23ms +1.30%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1401.6±34.32µs 1410.4±38.31µs +0.63%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 21.0±0.12ms 21.5±0.31ms +2.38%
Teleport evaluation 80.4±3.73µs 80.3±3.90µs -0.12%

@minestarks minestarks marked this pull request as ready for review April 17, 2024 17:58
Copy link

Benchmark for 85040d5

Click to view benchmark
Test Base PR %
Array append evaluation 337.1±4.21µs 345.2±2.48µs +2.40%
Array literal evaluation 180.1±4.07µs 193.3±4.50µs +7.33%
Array update evaluation 425.7±4.16µs 432.5±2.35µs +1.60%
Core + Standard library compilation 17.0±0.26ms 17.3±0.59ms +1.76%
Deutsch-Jozsa evaluation 5.0±0.05ms 5.0±0.05ms 0.00%
Large file parity evaluation 33.5±0.12ms 33.5±0.26ms 0.00%
Large input file compilation 11.5±0.20ms 11.5±0.24ms 0.00%
Large input file compilation (interpreter) 45.3±1.23ms 44.9±1.37ms -0.88%
Large nested iteration 33.0±0.24ms 34.1±0.39ms +3.33%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1494.0±27.31µs 1497.7±40.09µs +0.25%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.8±0.08ms 7.8±0.11ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1410.5±31.06µs 1409.6±32.82µs -0.06%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 21.3±0.46ms 21.2±0.53ms -0.47%
Teleport evaluation 80.2±3.61µs 80.1±3.35µs -0.12%

@minestarks minestarks added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit b3a81a2 Apr 17, 2024
17 checks passed
@minestarks minestarks deleted the minestarks/fix-auto-insert branch April 17, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants