Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint message formatting #1444

Merged
merged 5 commits into from
May 1, 2024
Merged

Fix lint message formatting #1444

merged 5 commits into from
May 1, 2024

Conversation

orpuente-MS
Copy link
Contributor

@orpuente-MS orpuente-MS commented Apr 29, 2024

When hovering over the squiggle generated by a Lint, the message in the first line appears twice. This PR removes the duplicated message. Fixes #1443

Currently, the error message is shown in the first line and in the last line, which is redundant:
image

This is how it looks after the change:
image

@swernli
Copy link
Collaborator

swernli commented Apr 29, 2024

FYI: the "fixes #1443" should be in the description rather than the title

@orpuente-MS orpuente-MS changed the title Fix lint message formatting. Fixes #1443 Fix lint message formatting Apr 29, 2024
@orpuente-MS
Copy link
Contributor Author

FYI: the "fixes #1443" should be in the description rather than the title

Thanks!

Copy link

Benchmark for d5de7eb

Click to view benchmark
Test Base PR %
Array append evaluation 340.3±3.85µs 341.0±1.93µs +0.21%
Array literal evaluation 190.5±2.78µs 190.1±2.37µs -0.21%
Array update evaluation 423.1±2.97µs 423.2±2.85µs +0.02%
Core + Standard library compilation 17.2±0.32ms 17.2±0.51ms 0.00%
Deutsch-Jozsa evaluation 5.1±0.05ms 5.1±0.16ms 0.00%
Large file parity evaluation 33.7±0.14ms 33.8±0.42ms +0.30%
Large input file compilation 11.6±0.40ms 11.5±0.16ms -0.86%
Large input file compilation (interpreter) 46.5±1.68ms 46.2±1.42ms -0.65%
Large nested iteration 33.2±0.14ms 33.4±0.14ms +0.60%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1498.1±30.37µs 1494.5±46.34µs -0.24%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.8±0.08ms 7.8±0.24ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1419.5±105.78µs 1404.9±30.35µs -1.03%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 21.3±0.21ms 21.4±0.21ms +0.47%
Teleport evaluation 80.9±4.24µs 82.8±4.99µs +2.35%

Copy link

Benchmark for f5732ed

Click to view benchmark
Test Base PR %
Array append evaluation 335.6±2.90µs 340.7±2.66µs +1.52%
Array literal evaluation 173.5±4.22µs 189.7±0.69µs +9.34%
Array update evaluation 418.5±4.70µs 424.4±2.05µs +1.41%
Core + Standard library compilation 16.8±0.22ms 16.9±0.52ms +0.60%
Deutsch-Jozsa evaluation 5.0±0.04ms 5.1±0.04ms +2.00%
Large file parity evaluation 33.6±0.10ms 33.6±0.45ms 0.00%
Large input file compilation 11.6±0.27ms 11.4±0.22ms -1.72%
Large input file compilation (interpreter) 45.1±1.42ms 45.2±1.37ms +0.22%
Large nested iteration 33.0±0.21ms 33.2±0.19ms +0.61%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1451.6±33.27µs 1491.8±28.85µs +2.77%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.7±0.07ms 7.7±0.08ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1366.4±35.95µs 1406.1±29.81µs +2.91%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 21.6±0.36ms 21.1±0.17ms -2.31%
Teleport evaluation 80.1±3.95µs 81.9±4.42µs +2.25%

@orpuente-MS orpuente-MS requested a review from billti April 29, 2024 22:50
@orpuente-MS orpuente-MS added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit 505e27a May 1, 2024
17 checks passed
@orpuente-MS orpuente-MS deleted the oscarpuente/fix-1443 branch May 1, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad formatting in lint reports
3 participants