-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lint message formatting #1444
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orpuente-MS
requested review from
billti,
idavis,
minestarks,
ScottCarda-MS and
swernli
as code owners
April 29, 2024 18:10
FYI: the "fixes #1443" should be in the description rather than the title |
orpuente-MS
changed the title
Fix lint message formatting. Fixes #1443
Fix lint message formatting
Apr 29, 2024
Thanks! |
Benchmark for d5de7ebClick to view benchmark
|
billti
reviewed
Apr 29, 2024
Benchmark for f5732edClick to view benchmark
|
swernli
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hovering over the squiggle generated by a Lint, the message in the first line appears twice. This PR removes the duplicated message. Fixes #1443
Currently, the error message is shown in the first line and in the last line, which is redundant:
This is how it looks after the change: