Update RCA for mutable Result, array, and tuple variables
#1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change strengthens RCA checks around use of mutable `Result`, array, and tuple variables in a dynamic context to make them consistent with how we verify the use of other dynamic value types like `Int` and `Double`. This gives users compile time feedback when updating a mutable value in a dynamic context will not produce QIR, rather than a codegen failure with `an unexpected error occurred related to: re-assignment within a dynamic branch is unsupported for type <type>` error.
Benchmark for c10e886Click to view benchmark
|
Benchmark for b2acc95Click to view benchmark
|
swernli
commented
May 24, 2024
Benchmark for 0da1cceClick to view benchmark
|
Benchmark for 84dae98Click to view benchmark
|
idavis
approved these changes
May 29, 2024
swernli
added a commit
that referenced
this pull request
Jun 3, 2024
This fixes a panic that was introduced in #1571, where if the content being used to update an array was a dynamic, non-array value it would panic when trying to aggreate a default array type into a element type. To make sure the update matches the chosen type, generate the `ValueKind` from the matching expression type. Added unit tests for both array and non-array dynamic update types.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
This fixes a panic that was introduced in #1571, where if the content being used to update an array was a dynamic, non-array value it would panic when trying to aggreate a default array type into a element type. To make sure the update matches the chosen type, generate the `ValueKind` from the matching expression type. Added unit tests for both array and non-array dynamic update types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change strengthens RCA checks around use of mutable
Result, array, and tuple variables in a dynamic context to make them consistent with how we verify the use of other dynamic value types likeIntandDouble. This gives users compile time feedback when updating a mutable value in a dynamic context will not produce QIR, rather than a codegen failure withan unexpected error occurred related to: re-assignment within a dynamic branch is unsupported for type <type>error.