-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler Validator Pass #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make sense to include calls to the validator in the compile
function in compiler/qsc_frontend/src/compile.rs. That way you can collect errors and surface them up in a way consistent with how parsing and symbol resolution errors work. That will involve introducing a new ErrorKind
alongside the existing ErrorKind::Parse
and ErrorKind::Resolve
, and then updating the new code in validate.rs to collect errors into an internal structure instead of using panic
. We chat more about the details here, but I think this is a good foundation so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor formatting comment, otherwise this looks good!
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Added a Validator pass to check that the submitted code does not contain:
Issue #71