forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RCTConvert] Deprecate UIBarStyle #2008
Labels
Comments
This was referenced Dec 29, 2023
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this issue
Dec 31, 2023
Summary: The enums [UIBarStyleBlackOpaque](https://developer.apple.com/documentation/uikit/uibarstyle/uibarstyleblackopaque) and [UIBarStyleBlackTranslucent](https://developer.apple.com/documentation/uikit/uibarstyle/uibarstyleblacktranslucent) have been deprecated since iOS 13, already below React Native's minimum OS of iOS 13.4. Indeed, they are not available on visionOS and tvOS, making this a source of extra diffs. Rather than deprecate and remove those options, I noticed that we don't actually use that `RCTConvert` method in the core repo, and haven't since `0.58-stable` (presumably before the lean core effort). Let's just remove it, it's a conversion that should be easy enough to replicate elsewhere. However, removal is a breaking change, so let's deprecate it for one release (0.74) and remove it for the next one (0.75). For posterity, tracking deprecation with microsoft#2008 and removal with microsoft#2009 . ## Changelog: [IOS] [DEPRECATED] - Deprecate `[RCTConvert UIBarStyle:]` Pull Request resolved: #42100 Test Plan: CI should pass Reviewed By: shwanton Differential Revision: D52458912 Pulled By: NickGerleman fbshipit-source-id: 5614b6624b9b929ba601ac976149b2002163ff54
Othinn
pushed a commit
to Othinn/react-native
that referenced
this issue
Jan 9, 2024
Summary: The enums [UIBarStyleBlackOpaque](https://developer.apple.com/documentation/uikit/uibarstyle/uibarstyleblackopaque) and [UIBarStyleBlackTranslucent](https://developer.apple.com/documentation/uikit/uibarstyle/uibarstyleblacktranslucent) have been deprecated since iOS 13, already below React Native's minimum OS of iOS 13.4. Indeed, they are not available on visionOS and tvOS, making this a source of extra diffs. Rather than deprecate and remove those options, I noticed that we don't actually use that `RCTConvert` method in the core repo, and haven't since `0.58-stable` (presumably before the lean core effort). Let's just remove it, it's a conversion that should be easy enough to replicate elsewhere. However, removal is a breaking change, so let's deprecate it for one release (0.74) and remove it for the next one (0.75). For posterity, tracking deprecation with microsoft#2008 and removal with microsoft#2009 . ## Changelog: [IOS] [DEPRECATED] - Deprecate `[RCTConvert UIBarStyle:]` Pull Request resolved: facebook#42100 Test Plan: CI should pass Reviewed By: shwanton Differential Revision: D52458912 Pulled By: NickGerleman fbshipit-source-id: 5614b6624b9b929ba601ac976149b2002163ff54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tasks
The text was updated successfully, but these errors were encountered: