Fix text replacement not working in multiline TextInput #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was due to some code in multiline TextInput which disabled all text checking types by default. We now match the system default instead.
harrieshin
reviewed
Jul 25, 2022
harrieshin
approved these changes
Jul 25, 2022
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
This bug was due to some code in multiline TextInput which disabled all text checking types by default. We now match the system default instead. Co-authored-by: Liron Yahdav <lyahdav@fb.com> # Conflicts: # Libraries/Text/TextInput/Multiline/RCTUITextView.m
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
This bug was due to some code in multiline TextInput which disabled all text checking types by default. We now match the system default instead. Co-authored-by: Liron Yahdav <lyahdav@fb.com> # Conflicts: # Libraries/Text/TextInput/Multiline/RCTUITextView.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This bug was due to some code in multiline TextInput which disabled all text checking types by default.
We now match the system default instead.
Changelog
[macOS] [Fixed] - Fix text replacement not working in multiline TextInput
Test Plan
Before
b.mov
After
a.mov