Pass callbacks for when grammarCheck, spellCheck and autoCorrect are changed on macOS #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophpurrer
force-pushed
the
grammarSpellcheckAutocorrectCallbacks2
branch
2 times, most recently
from
7f1c87d
to
83a9fa6
Compare
christophpurrer
changed the title
christophpurrer
force-pushed
the
grammarSpellcheckAutocorrectCallbacks2
branch
from
83a9fa6
to
a1911e5
Compare
Saadnajmi
reviewed
Aug 4, 2022
Saadnajmi
reviewed
Aug 4, 2022
Saadnajmi
reviewed
Aug 4, 2022
christophpurrer
force-pushed
the
grammarSpellcheckAutocorrectCallbacks2
branch
3 times, most recently
from
4e7d805
to
7c7745c
Compare
Saadnajmi
reviewed
Aug 5, 2022
christophpurrer
force-pushed
the
grammarSpellcheckAutocorrectCallbacks2
branch
from
7c7745c
to
2a02503
Compare
Saadnajmi
approved these changes
Aug 5, 2022
packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js
Outdated
Show resolved
Hide resolved
christophpurrer
force-pushed
the
grammarSpellcheckAutocorrectCallbacks2
branch
5 times, most recently
from
2dc1342
to
e5b1f71
Compare
|
This change seems to not compile on iOS, perhaps you're missing some '#IF_TARGET_OSX' somewhere? |
christophpurrer
force-pushed
the
grammarSpellcheckAutocorrectCallbacks2
branch
from
e5b1f71
to
9514849
Compare
Saadnajmi
reviewed
Aug 9, 2022
|
This should be good to go pending my one comment of Direct -> Bubbling! |
…changed on Mac [RFC] When users change spellCheck, grammarCheck or autoCorrect in the context menu, one of 3 callbacks for MULTILINE inputs are called: - toggleGrammarChecking - toggleContinuousSpellChecking - toggleAutomaticSpellingCorrection If JS is going to be the source of truth for text proofing settings, we should have a way to notify JS when these settings are changed from the native side.
christophpurrer
force-pushed
the
grammarSpellcheckAutocorrectCallbacks2
branch
from
9514849
to
b3d081f
Compare
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
…changed on Mac [RFC] (microsoft#1325) When users change spellCheck, grammarCheck or autoCorrect in the context menu, one of 3 callbacks for MULTILINE inputs are called: - toggleGrammarChecking - toggleContinuousSpellChecking - toggleAutomaticSpellingCorrection If JS is going to be the source of truth for text proofing settings, we should have a way to notify JS when these settings are changed from the native side. Co-authored-by: Alex Chiu <ackchiu@fb.com> # Conflicts: # Libraries/Text/TextInput/RCTBaseTextInputView.m # Libraries/Text/TextInput/RCTBaseTextInputViewManager.m # Conflicts: # Libraries/Components/TextInput/TextInput.js # packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js # Conflicts: # Libraries/Text/TextInput/RCTBackedTextInputDelegate.h # Libraries/Text/TextInput/RCTBaseTextInputView.h # Libraries/Text/TextInput/RCTBaseTextInputView.m # Libraries/Text/TextInput/RCTBaseTextInputViewManager.m
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
…changed on Mac [RFC] (microsoft#1325) When users change spellCheck, grammarCheck or autoCorrect in the context menu, one of 3 callbacks for MULTILINE inputs are called: - toggleGrammarChecking - toggleContinuousSpellChecking - toggleAutomaticSpellingCorrection If JS is going to be the source of truth for text proofing settings, we should have a way to notify JS when these settings are changed from the native side. Co-authored-by: Alex Chiu <ackchiu@fb.com> # Conflicts: # Libraries/Text/TextInput/RCTBaseTextInputView.m # Libraries/Text/TextInput/RCTBaseTextInputViewManager.m # Conflicts: # Libraries/Components/TextInput/TextInput.js # packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js # Conflicts: # Libraries/Text/TextInput/RCTBackedTextInputDelegate.h # Libraries/Text/TextInput/RCTBaseTextInputView.h # Libraries/Text/TextInput/RCTBaseTextInputView.m # Libraries/Text/TextInput/RCTBaseTextInputViewManager.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
When users change spellCheck, grammarCheck or autoCorrect in the context menu, one of 3 callbacks for MULTILINE inputs are called:
If JS is going to be the source of truth for text proofing settings, we should have a way to notify JS when these settings are changed from the native side.
Changelog
[macOS] [Added] - Pass callbacks for when grammarCheck, spellCheck and autoCorrect are changed on macOS
Test Plan
Added Example
Screen.Recording.2022-08-04.at.3.11.10.PM.mov