Add fragmentLinePadding for multiline shadow view to track TextView correctly #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrectly Shadow views are used to calculate the container's size using NSTextContainer + NSLayoutManager + NSTextStorage according to https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/TextLayout/Tasks/StringHeight.html. However, when typing certain text, the TextView itself overflows, but its container doesn't. This means our shadow view isn't tracking the TextView correctly. Root cause was that we added a 1px lineFragmentPadding in microsoft#640, but we didn't add the save padding in our shadow view. Test Plan: - Shrink app to minimum width - Type some text which overflows
christophpurrer
force-pushed
the
addFragmentLinePadding
branch
from
896fb20
to
5cb7144
Compare
Saadnajmi
approved these changes
Aug 9, 2022
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
…orrectly (microsoft#1332) Shadow views are used to calculate the container's size using NSTextContainer + NSLayoutManager + NSTextStorage according to https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/TextLayout/Tasks/StringHeight.html. However, when typing certain text, the TextView itself overflows, but its container doesn't. This means our shadow view isn't tracking the TextView correctly. Root cause was that we added a 1px lineFragmentPadding in microsoft#640, but we didn't add the save padding in our shadow view. Test Plan: - Shrink app to minimum width - Type some text which overflows Co-authored-by: Alex Chiu <ackchiu@fb.com>
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
…orrectly (microsoft#1332) Shadow views are used to calculate the container's size using NSTextContainer + NSLayoutManager + NSTextStorage according to https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/TextLayout/Tasks/StringHeight.html. However, when typing certain text, the TextView itself overflows, but its container doesn't. This means our shadow view isn't tracking the TextView correctly. Root cause was that we added a 1px lineFragmentPadding in microsoft#640, but we didn't add the save padding in our shadow view. Test Plan: - Shrink app to minimum width - Type some text which overflows Co-authored-by: Alex Chiu <ackchiu@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Shadow views are used to calculate the container's size using NSTextContainer + NSLayoutManager + NSTextStorage according to https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/TextLayout/Tasks/StringHeight.html.
However, when typing certain text, the TextView itself overflows, but its container doesn't.
This means our shadow view isn't tracking the TextView correctly.
Root cause was that we added a 1px lineFragmentPadding in #640, but we didn't add the save padding in our shadow view.
Changelog
[macOS] [Fixed] - Add fragmentLinePadding for multiline shadow view to track TextView correctly
Test Plan
Before
b.mov
After
a.mov