Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrollbar to multiline TextInput #1366

Merged
merged 27 commits into from
Aug 23, 2022
Merged

Conversation

chiuam
Copy link

@chiuam chiuam commented Aug 22, 2022

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 馃憤
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 馃憤
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Addresses #1364. This change adds scrollbar to multiline TextInput to indicate the text view is scrollable when possible.

Changelog

[Fixed] [macOS] - Add scrollbar to multiline TextInput

Test Plan

Before: No scrollbar when the text view is scrollable.

Before.mov

After: Scrollbar is shown after the text view becomes scrollable. (Note: Scrollbar remains visible if the text view is no longer scrollable.)

After.mov

chiuam and others added 26 commits May 19, 2022 17:24
@chiuam chiuam requested a review from a team as a code owner August 22, 2022 15:34
@Saadnajmi
Copy link
Collaborator

@christophpurrer Do you expect any issues to your side with this change? If so, like scrollEnabled, we can make showsVerticalScrollIndicator a configurable prop

@christophpurrer
Copy link

I think @shwanton is the best person to answer that question.
In doubt a configurable property to opt-in sounds good to me ;-)

@chiuam
Copy link
Author

chiuam commented Aug 23, 2022

Opened #1368 as a followup

@chiuam chiuam merged commit 96be39d into microsoft:main Aug 23, 2022
@chiuam chiuam deleted the textinput-scrollbar branch August 23, 2022 20:51
chiuam added a commit to chiuam/react-native-macos that referenced this pull request Aug 24, 2022
chiuam added a commit to chiuam/react-native-macos that referenced this pull request Aug 24, 2022
chiuam added a commit to chiuam/react-native-macos that referenced this pull request Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants