Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS 13 build error #1408

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Fix macOS 13 build error #1408

merged 1 commit into from
Sep 1, 2022

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Aug 31, 2022

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 馃憤
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 馃憤
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

For whatever reason, I need to update these headers to build on macOS 13 Ventura, Beta 4.

Error message before update:

error build: Definition of 'CIFilter' must be imported from module 'CoreImage.CIFilter' before it is required

Changelog

[macOS] [Fixed] - Fix macOS 13 build error

Test Plan

Builds on my local machine. I'm hoping the CI will inform me whether this change is valid on older macOS versions.

@Saadnajmi Saadnajmi requested a review from a team as a code owner August 31, 2022 23:42
@Saadnajmi
Copy link
Collaborator Author

Saadnajmi commented Sep 1, 2022

@harrieshin @mischreiber Between the 2 new headers, I think I only need the first one to build properly.

#import <CoreImage/CIFilter.h>
#import <CoreImage/CIVector.h> <-- Don't need this

I think I'd still rather include it for accuracy? We use both classes in code.

@Saadnajmi Saadnajmi merged commit 04ff142 into microsoft:main Sep 1, 2022
@Saadnajmi Saadnajmi deleted the ventura-fix branch September 1, 2022 22:49
@espipj
Copy link

espipj commented Dec 27, 2022

Hey! has this been released to ^0.64? by the docs this is the latest MacOS supported version right?

@Saadnajmi
Copy link
Collaborator Author

@espipj Sorry, the docs are out of date! The latest release is actually 0.68. This fix was back ported to our 0.66 and 0.68 releases with #1414 and #1415 (you can see the linked PRs in this PR).

We're currently working on our next release (0.71), and should have the docs updated then!

@espipj
Copy link

espipj commented Dec 29, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants