Fix drag and drop of files in multiline textfield when a custom draggedType property is used

[christophpurrer]

Please select one of the following

• I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
• I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
• I am making a fix / change for the macOS implementation of react-native
• I am making a change required for Microsoft usage of react-native

Summary

In #1429 I had naively assumed that NSPasteboardTypeFileURL is 1:1 replacement for the deprecated NSFilenamesPboardType property. It is not. It causes drag and drop of files from Finder to stop working when a pastedTypes property is set.

Changelog

[macOS][Fixed] - Fix drag and drop of files in multiline textfield when a custom draggedType property is used

Test Plan

Before

1.mov

After

2.mov

[Saadnajmi]

So if I understand correctly, this is a return to the deprecated API? Is there a "proper" way to use NSPasteboardTypeFileURL is pastedTypes is set?

[christophpurrer]

It is a deprecated property. Xcode emits this warning
react-native-macos/Libraries/Text/TextInput/RCTBaseTextInputView.m:684:68: warning build: 'NSFilenamesPboardType' is deprecated: first deprecated in macOS 10.14 - Create multiple pasteboard items with NSPasteboardTypeFileURL or kUTTypeFileURL instead

Well the suggestion of simply using NSPasteboardTypeFileURL does not lead to the same behavior.

It seems some Swift users even try to bring back the property > https://stackoverflow.com/questions/44537356/swift-4-nsfilenamespboardtype-not-available-what-to-use-instead-for-registerfo