Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Publish pipeline (take 3) #1774

Merged
merged 5 commits into from
Apr 4, 2023
Merged

Fix Publish pipeline (take 3) #1774

merged 5 commits into from
Apr 4, 2023

Conversation

Saadnajmi
Copy link
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 馃憤
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 馃憤
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Apparently yml treats booleans as Capital-T-True, not lowercase t 馃し馃従

Changelog

[MACOS] [FIXED] - Fix publish (take 3)

Test Plan

馃し馃従

@Saadnajmi Saadnajmi requested a review from a team as a code owner April 4, 2023 17:26
mischreiber
mischreiber approved these changes Apr 4, 2023
View reviewed changes
Copy link

@mischreiber mischreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T

@Saadnajmi
Copy link
Collaborator Author

Gonna do some YML copy/pasta to see if my fix will actually work.. so expect a bogus commit that will be force-pushed out

@Saadnajmi Saadnajmi merged commit 551e640 into microsoft:main Apr 4, 2023
16 of 17 checks passed
@Saadnajmi Saadnajmi deleted the fix-try-3 branch April 4, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischreiber mischreiber mischreiber approved these changes

@harrieshin harrieshin harrieshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Saadnajmi @mischreiber @harrieshin