Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code Libraries/Components/DatePickerAndroid #1803

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Remove dead code Libraries/Components/DatePickerAndroid #1803

merged 1 commit into from
Apr 28, 2023

Conversation

rozele
Copy link

@rozele rozele commented Apr 26, 2023

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 馃憤
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 馃憤
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This folder was removed upstream, and the macOS override at DatePickerAndroid.macos.js does not resolve to anything anyway.

Changelog

[GENERAL] [REMOVED] - Removed dead DatePickerAndroid.macos.js file

@rozele
Remove dead code Libraries/Components/DatePickerAndroid
1f4c447 
This folder was removed upstream, and the macOS override at DatePickerAndroid.macos.js does not resolve to anything anyway.
@rozele rozele requested a review from a team as a code owner April 26, 2023 15:24
@github-actions
Copy link

Warnings
鈿狅笍 馃搵 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 馃毇 dangerJS against 1f4c447

Saadnajmi
Saadnajmi approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@Saadnajmi Saadnajmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I guess I missed this one.

@Saadnajmi Saadnajmi merged commit 3589639 into microsoft:main Apr 28, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rozele @Saadnajmi