Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve from react instead of React #1808

Merged
merged 1 commit into from
May 1, 2023
Merged

Conversation

rozele
Copy link

@rozele rozele commented May 1, 2023

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 馃憤
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 馃憤
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This patches the ASAN RNTester example (which is RNTester specific) to import from 'react' instead of 'React'. There are two other RNTester modules that import from 'React' (ActivityIndicatorExample and CrashExample) that will get fixed once react-native-macos syncs past facebook#37185.

Changelog

[GENERAL] [FIXED] - Fixes import for ASANCrashExample in RNTester

Test Plan

GitHub CI passes

This patches the ASAN RNTester example (which is RNTester specific) to import from 'react' instead of 'React'. There are two other RNTester modules that import from 'React' (ActivityIndicatorExample and CrashExample) that will get fixed once react-native-macos syncs past facebook#37185.
@rozele rozele requested a review from a team as a code owner May 1, 2023 15:52
@Saadnajmi
Copy link
Collaborator

I'd be ok with cherry picking your change to the other two files if it helps you get your build faster. That's quite common practice.

@rozele
Copy link
Author

rozele commented May 1, 2023

I'd be ok with cherry picking your change to the other two files if it helps you get your build faster. That's quite common practice.

No need. We have a fork where we can include those changes. This was the only react-native-macos specific occurrence I could find.

@Saadnajmi Saadnajmi merged commit b58fa44 into microsoft:main May 1, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants