Use viewDidChangeBackingProperties to remove the use of notifications in RCTImageView

[lenaic]

Please select one of the following

• I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
• I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
• I am making a fix / change for the macOS implementation of react-native
• I am making a change required for Microsoft usage of react-native

Summary

In some rare cases a react native app on macOS would crash with the following message:

-[RCTImageView windowDidChangeBackingProperties:]: unrecognized selector sent to instance 0x10b0c2c00

The notification center is supposed to check if the object subscribed to the notification still exists before calling the registered selector for the notification. This is supposed to relieve us from having to remove the observer when deallocating the observing object.

In these rare crashes I assume another NSObject got allocated at the same address as what was previously an observing RCTImageView and the notification center may have considered the observer still active and sent the registered selector to it.

To fix the potential bug and also remove a couple differences with React Native this PR removes the need for notification subscriptions by using the NSView viewDidChangeBackingProperties instead.

Changelog

[macOS] [CHANGED] - Use viewDidChangeBackingProperties for image reloads on backing properties change

Test Plan

Tested by running RNTester on macOS with paper and dragging the window from a 1.0 backing scale factor display to a 2.0 backing scale factor display and checking that the image reload happens in the debugger.

Screen.Recording.2023-05-30.at.23.47.47.mov

[Saadnajmi]

Yay less code!