Update macOS init template to enable New Architecture

[shwanton]

Please select one of the following

• I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
• I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
• I am making a fix / change for the macOS implementation of react-native
• I am making a change required for Microsoft usage of react-native

Summary

**The default template was never upgraded to 0.71 and was not loading the new arch when RCT_NEW_ARCH_ENABLED=1 flag was passed to pod install

This PR picks #1853 to main

Changelog

[MACOS] [FIXED] - Update macOS init template to enable New Architecture

Test Plan

See test plan in #1853

[xysun]

This PR sets the macos app size under RCT to be a fixed 1024x768 (code), is there anyway I can override this number?

I tried update self.window in applicationDidFinishLaunching but all it did was open a new window with no view, the original view stays the same size.

NSScreen *screen = [NSScreen mainScreen];
  NSRect screenFrame = [screen visibleFrame];
  NSWindow *window = [[NSWindow alloc] initWithContentRect:screenFrame
                                                  styleMask:NSWindowStyleMaskTitled
                                                    backing:NSBackingStoreBuffered
                                                      defer:NO];

  [window makeKeyAndOrderFront:nil];
  self.window = window;

@Saadnajmi @shwanton thank you.

[Saadnajmi]

This PR sets the macos app size under RCT to be a fixed 1024x768 (code), is there anyway I can override this number?

I tried update self.window in applicationDidFinishLaunching but all it did was open a new window with no view, the original view stays the same size.

NSScreen *screen = [NSScreen mainScreen];
  NSRect screenFrame = [screen visibleFrame];
  NSWindow *window = [[NSWindow alloc] initWithContentRect:screenFrame
                                                  styleMask:NSWindowStyleMaskTitled
                                                    backing:NSBackingStoreBuffered
                                                      defer:NO];

  [window makeKeyAndOrderFront:nil];
  self.window = window;

@Saadnajmi @shwanton thank you.

To be clear, the window is not resizable? And you can't programmatically access the window/ set the frame afterwards?

[xysun]

The window is resizable. However I want to set the window size to screen size upon launch, I tried to set the frame in appdelegate:

NSScreen *screen = [NSScreen mainScreen];
  NSRect screenFrame = [screen visibleFrame];
  self.window.contentViewController.view.frame = screenFrame;
  [self.window setFrame:screenFrame display:YES];

This builds but doesn't change the launch window size though; I also tested using a 800x600 rect to make sure it's not a problem with mainScreen and that didn't work either.

[Saadnajmi]

@xysun Isee, ideally the user can specify their frame in their app, rather than our hardcoded default. To that end, I think the intention is RCTAppDelegate's createRootViewController method is the entry point for that. If the code was refactored so that instead of us hardcoding the constant, it came from the view controller (that you can override) would that work? Feel free to also submit a PR if that does!

Also, in case you want more control over your window and app delegate in general, this might be useful: https://github.com/microsoft/rnx-kit/blob/main/packages/react-native-host/README.md

[dev-johnny-gh]

@xysun
it took me 4 hours to resolve this issue, what a damn.

you can't pass any configs to RTCAppDelegate, you can search the RP code for "NSMakeRect(0,0,1024,768)", and you will see it's hardcoded.

you can't use applicationDidFinishLaunching to set up the window size, too. because the window is created on the superclass. at that moment, windows on sharedApplication are empty.

in the end, you have to do it on applicationDidBecomeActive hook.

- (void)applicationDidBecomeActive:(NSNotification *)notification {
  NSArray  *windows = [[UIApplication sharedApplication] windows];
  
  for (NSWindow  *window in windows) {
    if (window.isKeyWindow) {
      
      NSRect frame;
      
      frame.size.height = 680;
      frame.size.width = 400;
      
      [window setFrame:frame display:YES];
      [window center];

      break;
    }
  }
}