Add nil check to RCTBaseInputTextView #1895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Currently seeing a crash in RCTBaseInputTextView when attempting to change formatting via the touch bar (ex. changing colors). The crash is occurring somewhere in the textInputShouldChangeText method. Here is the crash stack:
The crash looks like it's happening when we're creating a dictionary, and as far as I can tell this is the only dictionary being created in this method. The error message is specifically complaining about the first entry into the dictionary being nil, so I added a nil check here.
Changelog
Test Plan
The crash is only repro'ing in ship builds, and not debug builds, so will validate whether this change fixes the issue once the change makes it into the right build.