[0.73] Merge up to 0.73-rc4

.circleci/config.yml

@@ -69,9 +69,9 @@ jobs:
                 command: |
                   if [[ -z "$CIRCLE_PULL_REQUEST" ]]; then
                     echo "Not in a PR. Can't filter properly outside a PR. Please open a PR so that we can run the proper CI tests."
-                    echo "Skipping!"
+                    echo "For safety, we run all the tests!"
                     mkdir -p /tmp/circleci/
-                    echo '{}' > /tmp/circleci/pipeline_config.json
+                    echo '{ "run_all": true }' > /tmp/circleci/pipeline_config.json
                   else
                     PR_NUMBER="${CIRCLE_PULL_REQUEST##*/}"
                     node ./scripts/circleci/pipeline_selection.js filter-jobs
@@ -91,4 +91,7 @@ jobs:
 workflows:
   always-run:
     jobs:
-      - choose_ci_jobs
+      - choose_ci_jobs:
+          filters:
+            tags:
+              only: /.*/

.circleci/configurations/top_level.yml

@@ -91,8 +91,8 @@ references:
     hermes_dsym_release_cache_key: &hermes_dsym_release_cache_key v1-hermes-release-dsym-{{ checksum "/tmp/hermes/hermesversion" }}-{{ checksum "/tmp/react-native-version" }}
     # Cocoapods - RNTester
     pods_cache_key: &pods_cache_key v10-pods-{{ .Environment.CIRCLE_JOB }}-{{ checksum "packages/rn-tester/Podfile.lock.bak" }}-{{ checksum "packages/rn-tester/Podfile" }}
-    cocoapods_cache_key: &cocoapods_cache_key v8-cocoapods-{{ .Environment.CIRCLE_JOB }}-{{ checksum "packages/rn-tester/Podfile.lock" }}-{{ checksum "packages/rn-tester/Podfile" }}-{{ checksum "/tmp/hermes/hermesversion" }}
-    rntester_podfile_lock_cache_key: &rntester_podfile_lock_cache_key v6-podfilelock-{{ .Environment.CIRCLE_JOB }}-{{ checksum "packages/rn-tester/Podfile" }}-{{ checksum "/tmp/week_year" }}-{{ checksum "/tmp/hermes/hermesversion" }}
+    cocoapods_cache_key: &cocoapods_cache_key v9-cocoapods-{{ .Environment.CIRCLE_JOB }}-{{ checksum "packages/rn-tester/Podfile.lock" }}-{{ checksum "packages/rn-tester/Podfile" }}-{{ checksum "/tmp/hermes/hermesversion" }}
+    rntester_podfile_lock_cache_key: &rntester_podfile_lock_cache_key v7-podfilelock-{{ .Environment.CIRCLE_JOB }}-{{ checksum "packages/rn-tester/Podfile" }}-{{ checksum "/tmp/week_year" }}-{{ checksum "/tmp/hermes/hermesversion" }}
 
     # Cocoapods - Template
     template_cocoapods_cache_key: &template_cocoapods_cache_key v4-cocoapods-{{ .Environment.CIRCLE_JOB }}-{{ checksum "/tmp/iOSTemplateProject/ios/Podfile.lock" }}-{{ checksum "/tmp/iOSTemplateProject/ios/Podfile" }}-{{ checksum "/tmp/hermes/hermesversion" }}-{{ checksum "packages/rn-tester/Podfile.lock }}

.circleci/configurations/workflows.yml

@@ -43,6 +43,7 @@ workflows:
           requires:
             - prepare_hermes_workspace
       - build_apple_slices_hermes:
+          filters: *only_release_tags
           requires:
             - build_hermesc_apple
           matrix:
@@ -54,6 +55,7 @@ workflows:
           requires:
             - prepare_hermes_workspace
       - build_hermes_macos:
+          filters: *only_release_tags
           requires:
             - build_apple_slices_hermes
           matrix:

.gitignore

@@ -21,7 +21,6 @@ DerivedData
 *.xcuserstate
 project.xcworkspace
 **/.xcode.env.local
-/poackages/react-native/sdks/downloads/
 
 # Gradle
 /build/

Gemfile

@@ -4,4 +4,4 @@ source 'https://rubygems.org'
 ruby ">= 2.6.10"
 
 gem 'cocoapods', '~> 1.12'
-gem 'activesupport', '>= 6.1.7.3'
+gem 'activesupport', '>= 6.1.7.3', '< 7.1.0'

flow-typed/npm/open_v7.x.x.js

@@ -0,0 +1,29 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow strict
+ * @format
+ * @oncall react_native
+ */
+
+declare module 'open' {
+  import type {ChildProcess} from 'child_process';
+
+  declare export type Options = $ReadOnly<{
+    wait?: boolean,
+    background?: boolean,
+    newInstance?: boolean,
+    allowNonzeroExitCode?: boolean,
+    ...
+  }>;
+
+  declare type open = (
+    target: string,
+    options?: Options,
+  ) => Promise<ChildProcess>;
+
+  declare module.exports: open;
+}

package.json

@@ -55,8 +55,8 @@
     "@definitelytyped/dtslint": "^0.0.127",
     "@jest/create-cache-key-function": "^29.6.3",
     "@pkgjs/parseargs": "^0.11.0",
-    "@react-native/metro-babel-transformer": "^0.73.11",
-    "@react-native/metro-config": "^0.73.0",
+    "@react-native/metro-babel-transformer": "^0.73.12",
+    "@react-native/metro-config": "^0.73.1",
     "@tsconfig/node18": "1.0.1",
     "@types/react": "^18.0.18",
     "@typescript-eslint/parser": "^5.57.1",
@@ -91,8 +91,8 @@
     "jest": "^29.6.3",
     "jest-junit": "^10.0.0",
     "jscodeshift": "^0.14.0",
-    "metro-babel-register": "0.79.1",
-    "metro-memory-fs": "0.79.1",
+    "metro-babel-register": "^0.80.0",
+    "metro-memory-fs": "^0.80.0",
     "micromatch": "^4.0.4",
     "mkdirp": "^0.5.1",
     "mock-fs": "^5.1.4",

packages/assets/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@react-native/assets-registry",
-  "version": "0.73.0",
+  "version": "0.73.1",
   "description": "Asset support code for React Native.",
   "license": "MIT",
   "repository": {
@@ -9,7 +9,12 @@
     "directory": "packages/assets"
   },
   "homepage": "https://github.com/facebook/react-native/tree/HEAD/packages/assets#readme",
-  "keywords": ["assets", "registry", "react-native", "support"],
+  "keywords": [
+    "assets",
+    "registry",
+    "react-native",
+    "support"
+  ],
   "bugs": "https://github.com/facebook/react-native/issues",
   "engines": {
     "node": ">=18"

packages/babel-plugin-codegen/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@react-native/babel-plugin-codegen",
-  "version": "0.73.0",
+  "version": "0.73.1",
   "description": "Babel plugin to generate native module and view manager code for React Native.",
   "license": "MIT",
   "repository": {
@@ -9,7 +9,14 @@
     "directory": "packages/babel-plugin-codegen"
   },
   "homepage": "https://github.com/facebook/react-native/tree/HEAD/packages/babel-plugin-codegen#readme",
-  "keywords": ["babel", "plugin", "codegen", "react-native", "native-modules", "view-manager"],
+  "keywords": [
+    "babel",
+    "plugin",
+    "codegen",
+    "react-native",
+    "native-modules",
+    "view-manager"
+  ],
   "bugs": "https://github.com/facebook/react-native/issues",
   "engines": {
     "node": ">=18"

packages/community-cli-plugin/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@react-native/community-cli-plugin",
-  "version": "0.73.1",
+  "version": "0.73.7",
   "description": "Core CLI commands for React Native",
   "keywords": [
     "react-native",
@@ -22,20 +22,20 @@
     "dist"
   ],
   "dependencies": {
-    "@react-native/dev-middleware": "^0.73.0",
-    "@react-native-community/cli-server-api": "12.0.0-alpha.15",
-    "@react-native-community/cli-tools": "12.0.0-alpha.15",
-    "@react-native/metro-babel-transformer": "^0.73.11",
+    "@react-native/dev-middleware": "^0.73.4",
+    "@react-native-community/cli-server-api": "12.0.0-alpha.17",
+    "@react-native-community/cli-tools": "12.0.0-alpha.17",
+    "@react-native/metro-babel-transformer": "^0.73.12",
     "chalk": "^4.0.0",
     "execa": "^5.1.1",
-    "metro": "0.79.1",
-    "metro-config": "0.79.1",
-    "metro-core": "0.79.1",
+    "metro": "^0.80.0",
+    "metro-config": "^0.80.0",
+    "metro-core": "^0.80.0",
     "node-fetch": "^2.2.0",
     "readline": "^1.3.0"
   },
   "devDependencies": {
-    "metro-resolver": "0.79.1"
+    "metro-resolver": "^0.80.0"
   },
   "engines": {
     "node": ">=18"

packages/community-cli-plugin/src/commands/start/attachKeyHandlers.js

@@ -15,35 +15,30 @@ import {logger} from '@react-native-community/cli-tools';
 import chalk from 'chalk';
 import execa from 'execa';
 import fetch from 'node-fetch';
-import readline from 'readline';
 import {KeyPressHandler} from '../../utils/KeyPressHandler';
 
 const CTRL_C = '\u0003';
 const CTRL_D = '\u0004';
 
 export default function attachKeyHandlers({
   cliConfig,
-  serverInstance,
   devServerUrl,
   messageSocket,
+  experimentalDebuggerFrontend,
 }: {
   cliConfig: Config,
   devServerUrl: string,
-  serverInstance: http$Server | https$Server,
   messageSocket: $ReadOnly<{
     broadcast: (type: string, params?: Record<string, mixed> | null) => void,
     ...
   }>,
+  experimentalDebuggerFrontend: boolean,
 }) {
   if (process.stdin.isTTY !== true) {
     logger.debug('Interactive mode is not supported in this environment');
     return;
   }
 
-  readline.emitKeypressEvents(process.stdin);
-  // $FlowIgnore[prop-missing]
-  process.stdin.setRawMode(true);
-
   const execaOptions = {
     env: {FORCE_COLOR: chalk.supportsColor ? 'true' : 'false'},
   };
@@ -83,30 +78,35 @@ export default function attachKeyHandlers({
         ).stdout?.pipe(process.stdout);
         break;
       case 'j':
+        if (!experimentalDebuggerFrontend) {
+          return;
+        }
         await fetch(devServerUrl + '/open-debugger', {method: 'POST'});
         break;
       case CTRL_C:
       case CTRL_D:
         logger.info('Stopping server');
-        listener?.({pause: true});
-        serverInstance.close(() => {
-          process.emit('SIGINT');
-          process.exit();
-        });
+        keyPressHandler.stopInterceptingKeyStrokes();
+        process.emit('SIGINT');
+        process.exit();
     }
   };
 
   const keyPressHandler = new KeyPressHandler(onPress);
-  const listener = keyPressHandler.createInteractionListener();
+  keyPressHandler.createInteractionListener();
   keyPressHandler.startInterceptingKeyStrokes();
 
   logger.log(
-    `
-${chalk.bold('i')} - run on iOS
-${chalk.bold('a')} - run on Android
-${chalk.bold('d')} - open Dev Menu
-${chalk.bold('j')} - open debugger
-${chalk.bold('r')} - reload app
-`,
+    [
+      '',
+      `${chalk.bold('i')} - run on iOS`,
+      `${chalk.bold('a')} - run on Android`,
+      `${chalk.bold('d')} - open Dev Menu`,
+      ...(experimentalDebuggerFrontend
+        ? [`${chalk.bold('j')} - open debugger (experimental, Hermes only)`]
+        : []),
+      `${chalk.bold('r')} - reload app`,
+      '',
+    ].join('\n'),
   );
 }

packages/community-cli-plugin/src/commands/start/index.js

@@ -95,6 +95,13 @@ const startCommand: Command = {
       name: '--no-interactive',
       description: 'Disables interactive mode',
     },
+    {
+      name: '--experimental-debugger',
+      description:
+        "[Experimental] Enable the new debugger experience and 'j' to " +
+        'debug. This enables the new frontend experience only: connection ' +
+        'reliability and some basic features are unstable in this release.',
+    },
   ],
 };
 

packages/community-cli-plugin/src/commands/start/runServer.js

@@ -33,6 +33,7 @@ export type StartCommandArgs = {
   assetPlugins?: string[],
   cert?: string,
   customLogReporterPath?: string,
+  experimentalDebugger: boolean,
   host?: string,
   https?: boolean,
   maxWorkers?: number,
@@ -118,7 +119,7 @@ async function runServer(
     logger,
     unstable_experiments: {
       // NOTE: Only affects the /open-debugger endpoint
-      enableCustomDebuggerFrontend: true,
+      enableNewDebugger: args.experimentalDebugger,
     },
   });
 
@@ -137,8 +138,8 @@ async function runServer(
         attachKeyHandlers({
           cliConfig: ctx,
           devServerUrl,
-          serverInstance,
           messageSocket: messageSocketEndpoint,
+          experimentalDebuggerFrontend: args.experimentalDebugger,
         });
       }
     },

packages/debugger-frontend/BUILD_INFO

@@ -1,5 +1,5 @@
-@generated SignedSource<<8a0bac4cfdcc3cd44a4f7136f2611ebb>>
-Git revision: 0ffb687b8e049769d2e7162ba8d7205c90e4110c
+@generated SignedSource<<7fdc9e65be03ba4c6654f14c6f23d645>>
+Git revision: 18f202a1ae468a01afb44ffd2f71d28023126989
 Built with --nohooks: false
 Is local checkout: false
 Remote URL: https://github.com/motiz88/rn-chrome-devtools-frontend

packages/debugger-frontend/dist/third-party/front_end/device_mode_emulation_frame.html

@@ -6,7 +6,7 @@
 <!DOCTYPE html>
 <html lang="en">
 <meta charset="utf-8">
-<title>DevTools</title>
+<title>DevTools (React Native)</title>
 <style>
   @media (prefers-color-scheme: dark) {
     body {
@@ -16,5 +16,6 @@
 </style>
 <meta http-equiv="Content-Security-Policy" content="object-src 'none'; script-src 'self' 'unsafe-eval' https://chrome-devtools-frontend.appspot.com">
 <meta name="referrer" content="no-referrer">
+<link rel="icon" href="./Images/favicon.ico">
 <script type="module" src="./entrypoints/device_mode_emulation_frame/device_mode_emulation_frame.js"></script>
 <body class="undocked" id="-blink-dev-tools">

packages/debugger-frontend/dist/third-party/front_end/devtools_app.html

@@ -6,7 +6,7 @@
 <!DOCTYPE html>
 <html lang="en">
 <meta charset="utf-8">
-<title>DevTools</title>
+<title>DevTools (React Native)</title>
 <style>
   @media (prefers-color-scheme: dark) {
     body {
@@ -16,5 +16,6 @@
 </style>
 <meta http-equiv="Content-Security-Policy" content="object-src 'none'; script-src 'self' 'unsafe-eval' https://chrome-devtools-frontend.appspot.com">
 <meta name="referrer" content="no-referrer">
+<link rel="icon" href="./Images/favicon.ico">
 <script type="module" src="./entrypoints/devtools_app/devtools_app.js"></script>
 <body class="undocked" id="-blink-dev-tools">