Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): handle DevServerHelper constructor signature change #1423

Merged
merged 2 commits into from
May 15, 2023
Merged

fix(android): handle DevServerHelper constructor signature change #1423

merged 2 commits into from
May 15, 2023

Conversation

tido64
Copy link
Member

@tido64 tido64 commented May 9, 2023

Description

The signature of the DevServerHelper constructor recently changed.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

# cherry-pick https://github.com/microsoft/react-native-test-app/pull/1388
npm run set-react-version nightly
yarn

# manually apply https://github.com/facebook/react-native/pull/37332
cd example
yarn android

Screenshots

0.71 nightly
Screenshot_1683633374 Screenshot_1683633107

@tido64 tido64 requested a review from kelset May 9, 2023 12:42
@github-actions github-actions bot added the platform: Android This affects Android label May 9, 2023
@tido64 tido64 merged commit 735a5db into trunk May 15, 2023
27 checks passed
@tido64 tido64 deleted the tido/update-devserverhelper branch May 15, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelset kelset kelset approved these changes

@arazabishov arazabishov Awaiting requested review from arazabishov

@sweggersen sweggersen Awaiting requested review from sweggersen

Assignees
No one assigned
Labels
platform: Android This affects Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tido64 @kelset