feat: Add visionOS Support #1803

Saadnajmi · 2024-01-29T23:35:03Z

Description

Add support to run visionOS apps with react-native-test-app, using @callstack/react-native-visionos. If one would like to override that and use a different fork (like react-native-macos, they can do so via the reactNativePath key of app.json.

Some caveats:

Separated setting @callstack/react-native-visionos as the default to commit a84c986 . I thought that was a good encapsulation of all the places we hardcode platform package names.
We use the iOS jsbundle for visonOS. That's how both @callstack/react-native-visionos and react-native-macos have set up their visionOS support.
I disabled booting and running tests on a visionOS simulator with c083feb. That passed for me locally, but fails in CI.
Some of the more "Extended" features like setting a custom app icon are not tested. visionOS in particular does use a different format App Icon, so I'm not sure that will work.

Platforms affected

Test plan

App launches. The new CI jobs (to be added) for visionOS should pass.

visionos/ReactTestApp/AppDelegate.swift

ios/test_app.rb

scripts/init.js

.github/actions/affected/action.yml

feat: Add visionOS Support

tido64

Great job! I'll try running this next week or so. For now, I've left some comments.

.github/labeler.yml

.github/workflows/build.yml

example/visionos/Podfile

scripts/xcodebuild.sh

tido64 · 2024-03-09T07:31:53Z

visionos/ReactTestApp.xcodeproj/project.pbxproj

+		192F052624AD3CC500A48456 /* ReactTestApp.release.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = ReactTestApp.release.xcconfig; sourceTree = "<group>"; };
+		192F052724AD3CC500A48456 /* ReactTestApp.common.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = ReactTestApp.common.xcconfig; sourceTree = "<group>"; };
+		192F052824AD3CC500A48456 /* ReactTestApp.debug.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = ReactTestApp.debug.xcconfig; sourceTree = "<group>"; };


Are the .xcconfig files for iOS close enough that we can reuse them?

Suggested change

192F052624AD3CC500A48456 /* ReactTestApp.release.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = ReactTestApp.release.xcconfig; sourceTree = "<group>"; };

192F052724AD3CC500A48456 /* ReactTestApp.common.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = ReactTestApp.common.xcconfig; sourceTree = "<group>"; };

192F052824AD3CC500A48456 /* ReactTestApp.debug.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = ReactTestApp.debug.xcconfig; sourceTree = "<group>"; };

192F052624AD3CC500A48456 /* ReactTestApp.release.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = ../ReactTestAppShared/ReactTestApp.release.xcconfig; sourceTree = "<group>"; };

192F052724AD3CC500A48456 /* ReactTestApp.common.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = ../ReactTestAppShared/ReactTestApp.common.xcconfig; sourceTree = "<group>"; };

192F052824AD3CC500A48456 /* ReactTestApp.debug.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = ../ReactTestAppShared/ReactTestApp.debug.xcconfig; sourceTree = "<group>"; };

The only difference is they set iOS deployment target instead of xros deployment target

Aha, maybe make them inherit the iOS ones and override that one prop?

Do we want to do the same for macOS? The differences are minor

I made an attempt: #1896
Happy to mess with naming now that there's an extra platform suffix.

visionos/ReactTestApp/Assets.xcassets/Contents.json

ReactTestApp-DevSupport.podspec

ios/test_app.rb

…to visionos

Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>

.github/labeler.yml

.github/workflows/build.yml

ReactTestApp-DevSupport.podspec

Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>

…to visionos

Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>

ios/ReactTestApp/AppDelegate.swift

Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>

This reverts commit 09144b4.

tido64

Thanks for all your work! This has been a huge effort! I think this is good to go now. There are a few tiny things I want to address, but I can do that in a separate PR.

tido64 · 2024-03-12T08:17:50Z

Wiki updated:

tido64 reviewed Jan 30, 2024

View reviewed changes

visionos/ReactTestApp/AppDelegate.swift Outdated Show resolved Hide resolved

tido64 reviewed Jan 30, 2024

View reviewed changes

ios/test_app.rb Outdated Show resolved Hide resolved

Saadnajmi force-pushed the visionos branch 5 times, most recently from fca3c60 to 10cab27 Compare February 13, 2024 00:15

Saadnajmi mentioned this pull request Feb 13, 2024

[visionOS] Link Accelerate Framework on visionOS microsoft/react-native-macos#2072

Merged

4 tasks

Saadnajmi force-pushed the visionos branch 2 times, most recently from bd54236 to b1a7b8b Compare February 15, 2024 19:58

matthargett mentioned this pull request Feb 15, 2024

React Native New Architecture BabylonJS/BabylonReactNative#595

Open

Saadnajmi force-pushed the visionos branch 2 times, most recently from 07b66ec to b0e3705 Compare February 15, 2024 23:22

Saadnajmi changed the title ~~Add visionOS Support~~ feat: Add visionOS Support Feb 15, 2024

Saadnajmi force-pushed the visionos branch 3 times, most recently from eff4b06 to 12560d3 Compare February 16, 2024 00:47

Saadnajmi commented Feb 16, 2024

View reviewed changes

ios/test_app.rb Outdated Show resolved Hide resolved

Saadnajmi commented Feb 16, 2024

View reviewed changes

scripts/init.js Outdated Show resolved Hide resolved

Saadnajmi commented Feb 16, 2024

View reviewed changes

scripts/init.js Outdated Show resolved Hide resolved

Saadnajmi force-pushed the visionos branch 2 times, most recently from 67f7bea to 63f29f1 Compare February 16, 2024 19:55

Saadnajmi marked this pull request as ready for review February 19, 2024 14:42

Saadnajmi requested a review from kelset as a code owner February 19, 2024 14:42

Saadnajmi commented Feb 19, 2024

View reviewed changes

.github/actions/affected/action.yml Show resolved Hide resolved

Saadnajmi mentioned this pull request Feb 20, 2024

fix(windows): fix init failing on Windows #1852

Merged

4 tasks

Saadnajmi force-pushed the visionos branch 3 times, most recently from 71d66cc to 22d8607 Compare March 3, 2024 22:42

Saadnajmi marked this pull request as draft March 3, 2024 22:42

Saadnajmi force-pushed the visionos branch 2 times, most recently from e6a3634 to c11f75d Compare March 8, 2024 23:07

Saadnajmi added 3 commits March 8, 2024 15:20

feat: Add visionOS Support

639f65b

feat: Add visionOS Support

Disable testing on visionOS simulator

c083feb

Set default to @callstack/react-native-visionos

a84c986

Saadnajmi force-pushed the visionos branch from c11f75d to a84c986 Compare March 8, 2024 23:20

Saadnajmi marked this pull request as ready for review March 8, 2024 23:38

Set CODEOWNERS

6928c28

tido64 reviewed Mar 9, 2024

View reviewed changes

Saadnajmi and others added 5 commits March 10, 2024 15:51

Merge branch 'trunk' of github.com:microsoft/react-native-test-app in…

50c4053

…to visionos

Update .github/labeler.yml

6571472

Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>

Apply suggestions from code review

acdbc4b

Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>

Make @callstack/react-native-visionos optional

1a7d1fb

Update lock

876b5e9

tido64 reviewed Mar 11, 2024

View reviewed changes

.github/labeler.yml Outdated Show resolved Hide resolved

.github/workflows/build.yml Show resolved Hide resolved

Saadnajmi commented Mar 11, 2024

View reviewed changes

ReactTestApp-DevSupport.podspec Outdated Show resolved Hide resolved

Saadnajmi commented Mar 11, 2024

View reviewed changes

ReactTestApp-DevSupport.podspec Outdated Show resolved Hide resolved

Saadnajmi and others added 4 commits March 11, 2024 06:38

Apply suggestions from code review

aab8c85

Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>

Merge branch 'trunk' of github.com:microsoft/react-native-test-app in…

61baece

…to visionos

Apply suggestions from code review

3329bb0

Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>

Copy RCTKeyWindow implementation

37a64e6

tido64 reviewed Mar 11, 2024

View reviewed changes

ios/ReactTestApp/AppDelegate.swift Outdated Show resolved Hide resolved

Saadnajmi and others added 4 commits March 11, 2024 09:02

Update AppDelegate.swift

7feba96

Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>

Update podfile

b1ca587

Update pack test

09144b4

Revert "Update pack test"

c6617d2

This reverts commit 09144b4.

tido64 approved these changes Mar 12, 2024

View reviewed changes

tido64 merged commit cc2ad04 into microsoft:trunk Mar 12, 2024
30 checks passed

Saadnajmi deleted the visionos branch March 12, 2024 18:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add visionOS Support #1803

feat: Add visionOS Support #1803

Saadnajmi commented Jan 29, 2024 •

edited

tido64 left a comment

tido64 Mar 9, 2024

Saadnajmi Mar 9, 2024

tido64 Mar 9, 2024

Saadnajmi Mar 11, 2024

Saadnajmi Mar 11, 2024

tido64 left a comment

tido64 commented Mar 12, 2024

feat: Add visionOS Support #1803

feat: Add visionOS Support #1803

Conversation

Saadnajmi commented Jan 29, 2024 • edited

Description

Platforms affected

Test plan

tido64 left a comment

Choose a reason for hiding this comment

tido64 Mar 9, 2024

Choose a reason for hiding this comment

Saadnajmi Mar 9, 2024

Choose a reason for hiding this comment

tido64 Mar 9, 2024

Choose a reason for hiding this comment

Saadnajmi Mar 11, 2024

Choose a reason for hiding this comment

Saadnajmi Mar 11, 2024

Choose a reason for hiding this comment

tido64 left a comment

Choose a reason for hiding this comment

tido64 commented Mar 12, 2024

Saadnajmi commented Jan 29, 2024 •

edited