Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(visionos): declare support for 0.74 #1933

Merged
merged 3 commits into from
Mar 25, 2024
Merged

fix(visionos): declare support for 0.74 #1933

merged 3 commits into from
Mar 25, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Mar 25, 2024

Description

Declare support for @callstack/react-native-visionos 0.74

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

npm run set-react-version 0.74
yarn remove react-native-macos --all
cd example
pod install --project-directory=visionos
yarn visionos

# In a separate terminal
yarn start

Screenshots

image

@tido64 tido64 requested a review from Saadnajmi March 25, 2024 07:34
@tido64 tido64 requested a review from kelset as a code owner March 25, 2024 07:34
@kelset
Copy link
Contributor

kelset commented Mar 25, 2024

I was able to test it locally and it all works, minus the --no-packager option, which is currently broken across the board for run-visionos.

A fix is coming up (callstack/react-native-visionos#134) but in the meantime I just removed it from the package.json script.

Screnshot:
Screenshot 2024-03-25 at 12 47 52

@kelset kelset enabled auto-merge (squash) March 25, 2024 13:49
@kelset kelset merged commit de07231 into trunk Mar 25, 2024
30 checks passed
@kelset kelset deleted the tido/visionos-0.74 branch March 25, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants