Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(windows): embed app manifest directly in code #1984

Merged
merged 5 commits into from
Apr 24, 2024
Merged

fix(windows): embed app manifest directly in code #1984

merged 5 commits into from
Apr 24, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Apr 22, 2024

Description

Embed app manifest directly in code

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

cd example/windows
yarn install-windows-test-app --use-nuget
yarn windows

# In a separate terminal
yarn start

@github-actions github-actions bot added platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: Windows This affects Windows platform: visionOS labels Apr 22, 2024
@tido64 tido64 mentioned this pull request Apr 22, 2024
Closed
4 tasks
@tido64 tido64 enabled auto-merge (squash) April 24, 2024 17:30
@tido64 tido64 merged commit bc35798 into trunk Apr 24, 2024
30 checks passed
@tido64 tido64 deleted the tido/remove-nlohmann-json branch April 24, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acoates-ms acoates-ms acoates-ms approved these changes

@kelset kelset Awaiting requested review from kelset kelset is a code owner

Assignees
No one assigned
Labels
platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS platform: Windows This affects Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tido64 @acoates-ms