Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): don't require camera permission in single app mode #1990

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Apr 24, 2024

Description

Don't require camera permission in single app mode.

This (ab)uses the android:maxSdkVersion property on uses-permission to disable the camera permission: https://developer.android.com/guide/topics/manifest/uses-permission-element

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

Multi-app mode Single-app mode
camera-permission no-permissions

@tido64 tido64 requested a review from kelset as a code owner April 24, 2024 11:45
@github-actions github-actions bot added the platform: Android This affects Android label Apr 24, 2024
Copy link
Member

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tido64 tido64 merged commit 669205a into trunk Apr 25, 2024
30 checks passed
@tido64 tido64 deleted the tido/camera-permission branch April 25, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Android This affects Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants