Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): ensure generated assets are included #2012

Merged
merged 1 commit into from
May 3, 2024
Merged

fix(android): ensure generated assets are included #2012

merged 1 commit into from
May 3, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented May 2, 2024

Description

Ensure generated assets are included. By using our own directory, we also avoid clashes and things will still work even if generated/rncli/src/main/* goes away in the future.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

cd example
yarn build:android
yarn android

@tido64 tido64 requested a review from kelset as a code owner May 2, 2024 12:46
@github-actions github-actions bot added the platform: Android This affects Android label May 2, 2024
kelset
kelset approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, and everything works as expected 👍

@tido64 tido64 merged commit 2f6784b into trunk May 3, 2024
30 checks passed
@tido64 tido64 deleted the tido/android-generated branch May 3, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelset kelset kelset approved these changes

Assignees
No one assigned
Labels
platform: Android This affects Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tido64 @kelset