fix(windows): unhandled exception thrown in std::_Xlen_string() #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
force-pushed
the
tido/fix-windows-build
branch
from
dda4759
to
c61cc7b
Compare
tido64
changed the title
tido64
force-pushed
the
tido/fix-windows-build
branch
7 times, most recently
from
009fb0c
to
b8b2fea
Compare
Current working directory when running tests (with VSTest.Console.exe) changed between Visual Studio 16.8 and 16.9 and broke our pipelines. To prevent future build failures, we'll use the absolute path to the test source file to build the path to the test fixtures.
tido64
force-pushed
the
tido/fix-windows-build
branch
from
b8b2fea
to
5cfa5eb
Compare
|
🎉 This PR is included in version 0.4.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current working directory when running tests (with
VSTest.Console.exe) changed between Visual Studio 16.8 and 16.9 and broke our pipelines. To prevent future build failures, we'll use the absolute path to the test source file to build the path to the test fixtures.Resolves #287.
Platforms affected
Test plan
Windows CI should pass.