fix(windows): JavaScriptMainModuleName is deprecated #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
`JavaScriptMainModuleName` was deprecated in 0.64, and removed in microsoft/react-native-windows@22e1206.
tido64
force-pushed
the
tido/JavaScriptMainModuleName-deprecated
branch
from
f529bdb
to
d20d521
Compare
kelset
approved these changes
Jun 18, 2021
|
🎉 This PR is included in version 0.5.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JavaScriptMainModuleNamewas deprecated in 0.64, and removed in microsoft/react-native-windows@22e1206.Caught with Windows nightly builds: https://github.com/microsoft/react-native-test-app/runs/2855115978?check_suite_focus=true
Platforms affected
Test plan
yarn clean yarn set-react-version 0.64 cd example yarn yarn build:windows yarn install-windows-test-app --use-nuget start windows/Example.sln yarn start:windowsBuild and run the test app. You should be able to switch between embedded and dev server.