Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for react-native 0.68 #739

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Feb 2, 2022

Description

Blocked by

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

  1. Set version 0.68:
    npm run set-react-version 0.68
    yarn
    cd example
    
  2. Build and run Android app:
    yarn android
    
  3. Build and run iOS app:
    rm -rf ios/Podfile.lock ios/Pods
    pod install --project-directory=ios
    yarn ios
    
  4. Enable Hermes by applying the patch below, and repeat step 3:
    diff --git a/example/ios/Podfile b/example/ios/Podfile
    index b6eae97..3d4a840 100644
    --- a/example/ios/Podfile
    +++ b/example/ios/Podfile
    @@ -4,7 +4,7 @@ workspace 'Example.xcworkspace'
    
     use_flipper! false if ENV['DISABLE_FLIPPER']
    
    -use_test_app! :hermes_enabled => false do |target|
    +use_test_app! :hermes_enabled => true do |target|
       target.tests do
         pod 'Example-Tests', :path => '..'
       end
  5. Build and run Windows app:
    yarn install-windows-test-app
    yarn windows
    
Screen Android (Hermes) iOS (JSC) iOS (Hermes) Windows
Home Screenshot_1643917255 image image n/a
App Screenshot_1643917264 image image image

@github-actions github-actions bot added the platform: Android This affects Android label Feb 2, 2022
@tido64 tido64 changed the title fix: declare support for react-native 0.68 fix: add support for react-native 0.68 Feb 2, 2022
@tido64 tido64 force-pushed the tido/support-rn-0.68 branch 3 times, most recently from f2384f8 to 2839e92 Compare February 8, 2022 13:04
@github-actions github-actions bot removed the platform: Android This affects Android label Feb 16, 2022
@github-actions github-actions bot added the platform: Android This affects Android label Feb 17, 2022
@tido64 tido64 force-pushed the tido/support-rn-0.68 branch 2 times, most recently from 427cf41 to 018f16a Compare February 22, 2022 20:15
@tido64 tido64 force-pushed the tido/support-rn-0.68 branch 2 times, most recently from a6e529b to 5d40c03 Compare March 28, 2022 14:05
@tido64
Copy link
Member Author

tido64 commented Mar 28, 2022

Last tested against:

{
  '@react-native-community/cli': '^7.0.3',
  '@react-native-community/cli-platform-android': '^7.0.1',
  '@react-native-community/cli-platform-ios': '^7.0.1',
  'hermes-engine': '~0.11.0',
  'metro-react-native-babel-preset': '0.67.0',
  react: '17.0.2',
  'react-native': '0.68.0-rc.4',
  'react-native-macos': undefined,
  'react-native-windows': '0.68.0-preview.7'
}

@tido64 tido64 marked this pull request as ready for review March 30, 2022 14:59
@tido64 tido64 requested a review from kelset March 30, 2022 14:59
@tido64 tido64 enabled auto-merge (squash) March 30, 2022 15:11
@tido64 tido64 merged commit f4920ca into trunk Mar 30, 2022
@tido64 tido64 deleted the tido/support-rn-0.68 branch March 30, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Android This affects Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants