-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: declare support for react-native 0.69 #891
Conversation
3a705a1
to
057a9a9
Compare
057a9a9
to
3fc607f
Compare
3fc607f
to
aaaa791
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, added a nit suggestion but feel free to proceed if you want 👍
@@ -17,10 +17,10 @@ | |||
"windows": "react-native run-windows --no-packager" | |||
}, | |||
"peerDependencies": { | |||
"react": "~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2", | |||
"react-native": "^0.0.0-0 || 0.62 - 0.68 || 1000.0.0", | |||
"react": "~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2 || ~18.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"react": "~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2 || ~18.0.0", | |
"react": "~16.11.0 || ~16.13.0 || ~17.0.0 || ~18.0.0", |
nit: since we use ~
we should just be able to use the .0 for the patch version, it will account for them all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, we shouldn't deviate from what react-native requires. By allowing the version number to go higher, we're basically allowing some leeway in case of emergencies. I don't think we should allow users to downgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that makes sense, in that case we can go
"react": "~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2 || ~18.0.0", | |
"react": "~16.11.0 || ~16.13.1 || ~17.0.1 || ~18.0.0", |
@@ -79,10 +79,10 @@ | |||
"@react-native-community/cli-platform-android": ">=4.10.0", | |||
"@react-native-community/cli-platform-ios": ">=4.10.0", | |||
"mustache": "^4.0.0", | |||
"react": "~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2", | |||
"react-native": "^0.0.0-0 || 0.62 - 0.68 || 1000.0.0", | |||
"react": "~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2 || ~18.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"react": "~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2 || ~18.0.0", | |
"react": "~16.11.0 || ~16.13.0 || ~17.0.0 || ~18.0.0", |
(same as above)
@@ -5364,10 +5364,10 @@ __metadata: | |||
react-native-test-app: "workspace:." | |||
react-native-windows: ^0.66.11 | |||
peerDependencies: | |||
react: ~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2 | |||
react-native: ^0.0.0-0 || 0.62 - 0.68 || 1000.0.0 | |||
react: ~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2 || ~18.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react: ~16.11.0 || ~16.13.1 || ~17.0.1 || ~17.0.2 || ~18.0.0 | |
react: ~16.11.0 || ~16.13.0 || ~17.0.0 || ~18.0.0 |
Description
Declare support for
react-native
0.69.Discussion: reactwg/react-native-releases#21
Platforms affected
Test plan