Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-navigation-stack causes errors when imported #4044

Closed
brukberhane opened this issue Feb 6, 2020 · 3 comments · Fixed by react-navigation/react-navigation#8570
Closed
Assignees
Labels
bug Extensions Tracks issues against community modules and extensions
Milestone

Comments

@brukberhane
Copy link

Environment

  • react-native Version: 0.60.6
  • react-native-windows Version: 0.60.0-vnext.136
  • Target Platform Version(s): 18362
  • Target Device(s): Desktop
  • Visual Studio Version: Visual Studio 2019
  • Build Configuration: Debug

Steps to Reproduce

react-native init <project> --version 0.60.6
cd <project>
yarn add rnpm-plugin-windows
react-native windows --template vnext
yarn add react-navigation react-navigation-stack

Expected Behavior

I would expect to be able to use the createStackNavigator function without any hiccups maybe minus the header.

Actual Behavior

Upon import of react-navigation-stack into the App.js fileimage
, I am greeted with an error that says:
image

Reproducible Demo

https://github.com/brukbrhane/rn-windows_navigation_demo.git

Additional context

I only found this error on the import of react-navigation-stack but it is prevalent in react-navigation-drawer but react-navigation-drawer doesn't show the error until you've tried to actually use createDrawerNavigator

@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Feb 6, 2020
@harinikmsft
Copy link
Contributor

@stmoy - can you check on the priority of this community module? It appears that this is a JS module and may have some bugs with the windows side of things. Will need to understand how high pri this is before funding it.

@stmoy
Copy link
Contributor

stmoy commented Feb 10, 2020

It looks like this is part of react-navigation, which is tracked here: #2546

This task is currently on the backlog and isn't actively funded right now, but has come up several times.

@harinikmsft harinikmsft added Extensions Tracks issues against community modules and extensions and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Feb 13, 2020
@harinikmsft harinikmsft added this to the Backlog milestone Feb 13, 2020
@harinikmsft
Copy link
Contributor

Moving this to backlog and assigned to @stmoy to figure out the right navigation module we want to add contribution to. We can tackle this once we identify our next steps.

@chrisglein chrisglein removed the vnext label Mar 18, 2020
joshuapinter pushed a commit to cntral/react-navigation that referenced this issue Sep 29, 2021
react-native-gesture-handler doesn't have Windows/macOS implementation yet, use the web version as stubs for now to enable navigation features for Windows and mac.

Close microsoft/react-native-windows#3884
Close microsoft/react-native-windows#4044
YAfullStack pushed a commit to YAfullStack/React-navigation that referenced this issue Dec 4, 2021
react-native-gesture-handler doesn't have Windows/macOS implementation yet, use the web version as stubs for now to enable navigation features for Windows and mac.

Close microsoft/react-native-windows#3884
Close microsoft/react-native-windows#4044
redhawkIT pushed a commit to redhawkIT/react-navigation that referenced this issue Dec 23, 2021
react-native-gesture-handler doesn't have Windows/macOS implementation yet, use the web version as stubs for now to enable navigation features for Windows and mac.

Close microsoft/react-native-windows#3884
Close microsoft/react-native-windows#4044
darkhorse-coder pushed a commit to darkhorse-coder/react-navigation that referenced this issue Apr 7, 2022
react-native-gesture-handler doesn't have Windows/macOS implementation yet, use the web version as stubs for now to enable navigation features for Windows and mac.

Close microsoft/react-native-windows#3884
Close microsoft/react-native-windows#4044
nenad0212 pushed a commit to nenad0212/temp1 that referenced this issue Sep 6, 2022
react-native-gesture-handler doesn't have Windows/macOS implementation yet, use the web version as stubs for now to enable navigation features for Windows and mac.

Close microsoft/react-native-windows#3884
Close microsoft/react-native-windows#4044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Extensions Tracks issues against community modules and extensions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants