feat: add Windows and macOS support #8570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiguo
force-pushed
the
add-windows-support
branch
from
143517f
to
832aa5c
Compare
kaiguo
force-pushed
the
add-windows-support
branch
from
832aa5c
to
f379a97
Compare
|
could you also add react-native-macos support while at it : |
Yep, added : ) |
|
react-native-gesture-handler does not support macos |
kaiguo
force-pushed
the
add-windows-support
branch
from
02911c1
to
3aa0be7
Compare
satya164
requested changes
Jul 28, 2020
kaiguo
force-pushed
the
add-windows-support
branch
from
c45d523
to
9e20b9c
Compare
|
Thanks @satya164! Just pushed out another commit to address your feedbacks. |
|
Hey @satya164 do we know when the next release will be? Looks like the current release doesn't have this change and your refactor yet. |
|
I need to finish some other stuff before doing a release |
|
Waiting for the release as well |
|
Is MacOS supported now? |
joshuapinter
pushed a commit
to cntral/react-navigation
that referenced
this pull request
Sep 29, 2021
react-native-gesture-handler doesn't have Windows/macOS implementation yet, use the web version as stubs for now to enable navigation features for Windows and mac. Close microsoft/react-native-windows#3884 Close microsoft/react-native-windows#4044
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-native-gesture-handler doesn't have Windows/macOS implementation yet, use the web version as stubs for now to enable navigation features for Windows and mac.
Close microsoft/react-native-windows#3884
Close microsoft/react-native-windows#4044