codegen-windows command run with --check command always fails #11187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the
--checkoption oncodegen-windowsalways fails, due to it not correctly finding the already generated files.Also the codegen-windows file is not correctly deleting files that should not exist anymore, such as when a spec file is deleted.
I also added a run of the check logic as part of lint for the vnext project, to ensure that the codegen'd output doesn't get out of sync with the code checked in. (Which is appears to have done - likely as part of the RN integration)
Microsoft Reviewers: Open in CodeFlow