Add changes to disabled property for components (e.g TouchableHighlight) #11253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added changes to prevent components that are disabled from being keyboard focusable. Used TouchableHighlight issue #8875 as example.
Type of Change
Why
Resolves [#8875 ]
What
Added logic to check
disabledproperty on components and, if true, make them not focusable.Screenshots
After:
Testing
Tested on a TouchableHighlight component in playground. As shown in image above, hanges were not effective, as even with
disabled={true}, component still receives keyboard focus.Microsoft Reviewers: Open in CodeFlow