Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.71] ABI-safe Hermes API and new JSI for Node-API (#11696) #11757

Merged
merged 7 commits into from
Jun 14, 2023
Merged

[0.71] ABI-safe Hermes API and new JSI for Node-API (#11696) #11757

merged 7 commits into from
Jun 14, 2023

Conversation

vmoroz
Copy link
Member

@vmoroz vmoroz commented Jun 14, 2023 •
edited by microsoft-github-policy-service bot

Cherry pick PR #11033 and #11696.
PR #11033: Enable Hermes sampling profiler for RNW project.
PR #11696: ABI-safe Hermes API and new JSI for Node-API
The PR has the following set of changes:

  • Use new Hermes DLL that has only C-based API.
  • Use new V8 DLL that has new API matching the Hermes DLL API.
  • Use new JSI for Node-API implementation from node-api-jsi repo.
  • Remove use of non-ABI safe V8 JSI Runtime.
Microsoft Reviewers: Open in CodeFlow

@vmoroz vmoroz requested a review from acoates-ms June 14, 2023 05:21
@vmoroz vmoroz requested review from a team as code owners June 14, 2023 05:21
@vmoroz
Copy link
Member Author

vmoroz commented Jun 14, 2023 •
edited

Wrong target branch...
Update: I managed to fix the target base branch.

@vmoroz vmoroz closed this Jun 14, 2023
@vmoroz vmoroz reopened this Jun 14, 2023
@vmoroz vmoroz closed this Jun 14, 2023
@vmoroz vmoroz reopened this Jun 14, 2023
@vmoroz vmoroz changed the base branch from main to 0.71-stable June 14, 2023 05:27
@vmoroz vmoroz changed the title [0.72] ABI-safe Hermes API and new JSI for Node-API (#11696) [0.71] ABI-safe Hermes API and new JSI for Node-API (#11696) Jun 14, 2023
@acoates-ms acoates-ms merged commit 7a340bd into microsoft:0.71-stable Jun 14, 2023
78 checks passed
@vmoroz vmoroz deleted the PR/0.71-abi-safe-hermes branch June 14, 2023 15:33
vmoroz added a commit to vmoroz/react-native-windows that referenced this pull request Jun 20, 2023
@vmoroz
Revert "[0.71] ABI-safe Hermes API and new JSI for Node-API (microsof…
d582c85 
…t#11696) (microsoft#11757)"

This reverts commit 7a340bd.
acoates-ms pushed a commit that referenced this pull request Jun 20, 2023
@vmoroz
[0.71] Revert PR #11757 that added use of hermes.dll with C API (#11788)
569d940 
* Revert "[0.71] ABI-safe Hermes API and new JSI for Node-API (#11696) (#11757)"

This reverts commit 7a340bd.

* Change files
vmoroz added a commit to vmoroz/react-native-windows that referenced this pull request Jul 5, 2023
@vmoroz
Revert "[0.71] Re-apply PR microsoft#11757 that added use of hermes.d…
203b272 
…ll with C API (microsoft#11788)"

This reverts commit 569d940.
@vmoroz vmoroz mentioned this pull request Jul 5, 2023
Merged
vmoroz added a commit that referenced this pull request Jul 20, 2023
@vmoroz
[0.71] Re-apply PR #11757 that added use of hermes.dll with C API (#1…
4a0a6e0 
…1838)

* Revert "[0.71] Re-apply PR #11757 that added use of hermes.dll with C API (#11788)"

This reverts commit 569d940.

* Fix V8 instantiation

* Change files
JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request Jul 29, 2023
@JunielKatarn
Revert "[0.71] Re-apply PR microsoft#11757 that added use of hermes.d…
ed9a240 
…ll with C API (microsoft#11838)"

This reverts commit 4a0a6e0.
JunielKatarn added a commit that referenced this pull request Jul 29, 2023
@JunielKatarn
Revert #11838 - Re-apply "ABI-safe Hermes API and new JSI for Node-AP…
5cd9b23 
…I" (#11958)

* Revert "[0.71] Re-apply PR #11757 that added use of hermes.dll with C API (#11838)"

This reverts commit 4a0a6e0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acoates-ms acoates-ms acoates-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vmoroz @acoates-ms