Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.71] Re-apply PR #11757 that added use of hermes.dll with C API #11838

Merged
merged 4 commits into from
Jul 20, 2023
Merged

[0.71] Re-apply PR #11757 that added use of hermes.dll with C API #11838

merged 4 commits into from
Jul 20, 2023

Conversation

vmoroz
Copy link
Member

@vmoroz vmoroz commented Jul 5, 2023 •
edited by microsoft-github-policy-service bot

Re-apply PR #11757. Original description:

Cherry pick PR #11033 and #11696.
PR #11033: Enable Hermes sampling profiler for RNW project.
PR #11696: ABI-safe Hermes API and new JSI for Node-API
The PR has the following set of changes:

  • Use new Hermes DLL that has only C-based API.
  • Use new V8 DLL that has new API matching the Hermes DLL API.
  • Use new JSI for Node-API implementation from node-api-jsi repo.
  • Remove use of non-ABI safe V8 JSI Runtime.

New in this PR:
Fix V8 instantiation - cherry pick PR #11800

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/react-native-windows/pull/11838&drop=dogfoodAlpha

@vmoroz vmoroz requested a review from acoates-ms July 5, 2023 15:20
@vmoroz vmoroz requested review from a team as code owners July 5, 2023 15:20
chiaramooney
chiaramooney approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@chiaramooney chiaramooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vmoroz vmoroz merged commit 4a0a6e0 into microsoft:0.71-stable Jul 20, 2023
78 checks passed
@vmoroz vmoroz deleted the 0.71-hermes_api branch July 20, 2023 20:14
JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request Jul 29, 2023
@JunielKatarn
Revert "[0.71] Re-apply PR microsoft#11757 that added use of hermes.d…
ed9a240 
…ll with C API (microsoft#11838)"

This reverts commit 4a0a6e0.
@JunielKatarn JunielKatarn mentioned this pull request Jul 29, 2023
Merged
JunielKatarn added a commit that referenced this pull request Jul 29, 2023
@JunielKatarn
Revert #11838 - Re-apply "ABI-safe Hermes API and new JSI for Node-AP…
5cd9b23 
…I" (#11958)

* Revert "[0.71] Re-apply PR #11757 that added use of hermes.dll with C API (#11838)"

This reverts commit 4a0a6e0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonthysell jonthysell jonthysell approved these changes

@chiaramooney chiaramooney chiaramooney approved these changes

@acoates-ms acoates-ms Awaiting requested review from acoates-ms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vmoroz @jonthysell @chiaramooney