Expose ImageProps from ImageComponentView's and add ImageSource type #13206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a new
ImageProps
object to allow querying of properties fromImageComponentView
s. This also includes adding a newImageSource
type, with aReadValue
function, which can be used by custom components needing to parseImageSource
types from JS, and in future codegen of custom Props objects.Open Question
Ideally the props would be exposed as:
However, I'm not sure if that kind of override is supported and didn't have much luck making it. So instead, I added a separate
ImageProps
property toImageComponentView
. If anyone knows how to get the above to work that would be a cleaner interface.Microsoft Reviewers: Open in CodeFlow