Fix Content-Type custom payload bugs #888
Conversation
When a custom payload body is used to work around unsupported content types, the Content-Type
header must also be modified via the dictionary. This functionality had several bugs, which
are fixed in this change. After this update, using either `restler_custom_payload_header` or
`restler_custom_payload` with the request-specific syntax for dictionary payloads now works
as expected, for example:
"restler_custom_payload": {
"/stores/{storeId}/order/post/Content-Type": [ "xml" ]
}
This change also fixes the same bugs with per-request syntax with restler_custom_payload_query.
Testing:
- manual testing with demo_server
- added new compiler tests
| sprintf "%s/%s/%s" endpoint (method.ToLower()) propertyNameOrPath | ||
|
|
||
| member x.isRequestTypePayloadName endpoint (method:string) (propertyValue:string) = | ||
| let prefix = sprintf "%s/%s" endpoint (method.ToLower()) |
There was a problem hiding this comment.
Should prefix include a trailing / like it does here in getRequestTypePayloadPrefix?
member x.getRequestTypePayloadPrefix endpoint (method:string) =
sprintf "%s/%s/" endpoint (method.ToLower())
Wondering if there could be an issue here with this code and propertyValue.StartsWith(prefix) incorrectly matching with a prefix that's actually a substring of propertyValue:
prefix = "foo/bar"
propertyValue = "foo/bar2" #Resolved
| // No headers in Swagger | ||
| let injectedCustomPayloadHeaderParameters = getInjectedHeaderOrQueryParameters [] CustomPayloadType.Header | ||
| if injectedCustomPayloadHeaderParameters |> Seq.isEmpty then | ||
| // TODO: remove this branch and update grammar.py test baselines |
There was a problem hiding this comment.
Just wanted to check if this TODO is for this PR, or if it's to be addressed in future set of changes. #Pending
There was a problem hiding this comment.
It's for a future set of changes, updating the grammar.json files is a bit time consuming - in addition to the compiler updates, need to make sure the engine can consume the new grammar.json files and this particular change could introduce a regression.
When a custom payload body is used to work around unsupported content types, the Content-Type header must also be modified via the dictionary. This functionality had several bugs, which are fixed in this change. After this update, using either
restler_custom_payload_headerorrestler_custom_payloadwith the request-specific syntax for dictionary payloads now works as expected, for example:"restler_custom_payload": {
"/stores/{storeId}/order/post/Content-Type": [ "xml" ]
}
This change also fixes the same bugs with per-request syntax with restler_custom_payload_query.
Testing: