Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config-files.md #2457

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Update config-files.md #2457

merged 2 commits into from
Apr 3, 2024

Conversation

zandiarash
Copy link

@zandiarash zandiarash commented Mar 31, 2024 •
edited
Loading

I've changed configuration and removed unnecessary commas.
Fixes #2458

@zandiarash
Update config-files.md
726bc3c 
I've removed unnecessary commas.
@zandiarash zandiarash mentioned this pull request Mar 31, 2024
Closed
@MihaZupan MihaZupan added this to the v.Next milestone Apr 2, 2024
@MihaZupan MihaZupan added the Type: Documentation Improvements or additions to documentation label Apr 2, 2024
MihaZupan
MihaZupan approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I pushed another commit that applies similar changes to other json samples

@MihaZupan
Copy link
Member

@zandiarash please check the CLA above when you get a chance

@zandiarash
Copy link
Author

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

@MihaZupan MihaZupan merged commit 8087b3e into microsoft:release/latest Apr 3, 2024
2 checks passed
@MihaZupan MihaZupan mentioned this pull request Apr 3, 2024
Merged
@zandiarash zandiarash deleted the patch-1 branch April 3, 2024 16:35
@zandiarash
Copy link
Author

zandiarash commented Apr 3, 2024 •
edited
Loading

Dear @MihaZupan
I wanted to express my sincere gratitude for merging my pull request into the project. Your prompt response and willingness to incorporate my changes mean a lot to me. 🙌
I truly appreciate your efforts in maintaining this repository and fostering a collaborative environment.
Once again, thank you for your time and consideration!

@MihaZupan MihaZupan modified the milestones: v.Next, YARP 2.2.0-preview1 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MihaZupan MihaZupan MihaZupan approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Milestone
YARP 2.2.0-preview1
Development

Successfully merging this pull request may close these issues.
2 participants
@zandiarash @MihaZupan