New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Arcade #29
Install Arcade #29
Conversation
<Import Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" /> | ||
|
||
<PropertyGroup> | ||
<Copyright>© Microsoft Corporation. All rights reserved.</Copyright> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentional. Proxy is not a .NET Foundation product at this time.
NuGet.config
Outdated
@@ -2,6 +2,13 @@ | |||
<configuration> | |||
<packageSources> | |||
<clear /> | |||
<!-- Feed to use to restore the Arcade SDK from --> | |||
<add key="dotnet-core" value="https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 'dotnet-eng' (https://github.com/dotnet/aspnetcore/blob/10a99c099079adc96e1c53aacbe4b46c4b60859d/NuGet.config#L6)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got that from the ref docs. Sent dotnet/arcade#5165 to update.
@@ -0,0 +1,2 @@ | |||
@echo off | |||
powershell -ExecutionPolicy ByPass -NoProfile -command "& """%~dp0eng\common\Build.ps1""" -test %*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these strictly conveniences (test, restore, pack, activate, etc)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they are similar to ones in dotnet/aspnetcore. Conveniences for local dev only.
This looks to have everything it needs to ingest future updates of Arcade, just need to add a darc subscription (which isn't a code change) |
Yep, and I'll turn that on when this is merged (I'd like to do it to learn how ;)). |
538dd71
to
2c20885
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable assuming build doesn't break after resolving the merge conflicts
Hah! What build? :P |
Installs dotnet/arcade into this repo and sets up basic scripts. Not included: CI/CD pipeline or dependency flow of new arcade (that will come in a future PR)
Part of #5 (but does not close it).
cc @wtgodbe @mmitche because they know Arcade stuff. Would appreciate any feedback you're able to give.