Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Arcade #29

Merged
merged 4 commits into from Mar 31, 2020
Merged

Install Arcade #29

merged 4 commits into from Mar 31, 2020

Conversation

analogrelay
Copy link
Contributor

Installs dotnet/arcade into this repo and sets up basic scripts. Not included: CI/CD pipeline or dependency flow of new arcade (that will come in a future PR)

Part of #5 (but does not close it).

cc @wtgodbe @mmitche because they know Arcade stuff. Would appreciate any feedback you're able to give.

<Import Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" />

<PropertyGroup>
<Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional. Proxy is not a .NET Foundation product at this time.

@analogrelay analogrelay mentioned this pull request Mar 31, 2020
6 tasks
NuGet.config Outdated
@@ -2,6 +2,13 @@
<configuration>
<packageSources>
<clear />
<!-- Feed to use to restore the Arcade SDK from -->
<add key="dotnet-core" value="https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got that from the ref docs. Sent dotnet/arcade#5165 to update.

@@ -0,0 +1,2 @@
@echo off
powershell -ExecutionPolicy ByPass -NoProfile -command "& """%~dp0eng\common\Build.ps1""" -test %*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these strictly conveniences (test, restore, pack, activate, etc)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are similar to ones in dotnet/aspnetcore. Conveniences for local dev only.

@wtgodbe
Copy link
Member

wtgodbe commented Mar 31, 2020

Not included: CI/CD pipeline or dependency flow of new arcade (that will come in a future PR)

This looks to have everything it needs to ingest future updates of Arcade, just need to add a darc subscription (which isn't a code change)

@analogrelay
Copy link
Contributor Author

Yep, and I'll turn that on when this is merged (I'd like to do it to learn how ;)).

Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable assuming build doesn't break after resolving the merge conflicts

@analogrelay
Copy link
Contributor Author

Hah! What build? :P

@analogrelay analogrelay merged commit 8273d16 into master Mar 31, 2020
@analogrelay analogrelay deleted the anurse/5-arcade branch March 31, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants