Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FluentAssertion #69

Merged
merged 3 commits into from
Apr 20, 2020
Merged

Remove FluentAssertion #69

merged 3 commits into from
Apr 20, 2020

Conversation

Kahbazi
Copy link
Collaborator

@Kahbazi Kahbazi commented Apr 18, 2020

Fixes #30

@msftclas
Copy link

msftclas commented Apr 18, 2020 •
edited

CLA assistant check
All CLA requirements met.

@Tratcher Tratcher self-assigned this Apr 18, 2020
@Tratcher
Copy link
Member

Thanks

@Tratcher Tratcher merged commit 3536f31 into microsoft:master Apr 20, 2020
@Tratcher Tratcher added this to the 1.0.0-preview1 milestone Apr 20, 2020
@Kahbazi Kahbazi deleted the kahbazi/removeFluentAssertion branch April 21, 2020 09:07
@analogrelay analogrelay mentioned this pull request Apr 24, 2020
Closed
@abatishchev
Copy link

Why you've removed FA? I personally find it for flexible and feature-rich, tests that use it more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@halter73 halter73 Awaiting requested review from halter73

Assignees

@Tratcher Tratcher

Labels
None yet
Projects
None yet
Milestone
1.0.0-preview1
Development

Successfully merging this pull request may close these issues.

Remove FluentAssertions
4 participants
@Kahbazi @msftclas @Tratcher @abatishchev