fix(web-storage): migrate away from `com.facebook.react.turbomodule.c…

…ore.interfaces.TurboModule` (#2989)
microsoft · Feb 28, 2024 · 22420d7 · 22420d7
1 parent 0eb1198
commit 22420d7
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/early-zebras-laugh.md b/.changeset/early-zebras-laugh.md
@@ -0,0 +1,5 @@
+---
+"@react-native-webapis/web-storage": patch
+---
+
+Migrate away from `com.facebook.react.turbomodule.core.interfaces.TurboModule` as it has been moved/renamed in 0.74 and will break TurboModule detection
diff --git a/.../web-storage/android/src/main/java/org/reactnativewebapis/webstorage/WebStoragePackage.kt b/.../web-storage/android/src/main/java/org/reactnativewebapis/webstorage/WebStoragePackage.kt
@@ -5,7 +5,6 @@ import com.facebook.react.bridge.NativeModule
 import com.facebook.react.bridge.ReactApplicationContext
 import com.facebook.react.module.model.ReactModuleInfo
 import com.facebook.react.module.model.ReactModuleInfoProvider
-import com.facebook.react.turbomodule.core.interfaces.TurboModule
 
 class WebStoragePackage : TurboReactPackage() {
     override fun getModule(name: String, reactContext: ReactApplicationContext): NativeModule {
@@ -23,7 +22,7 @@ class WebStoragePackage : TurboReactPackage() {
             false,
             false,
             false,
-            TurboModule::class.java.isAssignableFrom(WebStorageModule::class.java)
+            WebStorageModule.IS_TURBO_MODULE
         )
         mapOf(info.name() to info).toMutableMap()
     }

diff --git a/...eb-storage/android/src/newarch/java/org/reactnativewebapis/webstorage/WebStorageModule.kt b/...eb-storage/android/src/newarch/java/org/reactnativewebapis/webstorage/WebStorageModule.kt
@@ -8,6 +8,7 @@ import com.facebook.react.bridge.ReactApplicationContext
 class WebStorageModule(context: ReactApplicationContext) : NativeWebStorageSpec(context) {
 
     companion object {
+        const val IS_TURBO_MODULE = true
         const val NAME = NativeWebStorageSpec.NAME
     }
 

diff --git a/...eb-storage/android/src/oldarch/java/org/reactnativewebapis/webstorage/WebStorageModule.kt b/...eb-storage/android/src/oldarch/java/org/reactnativewebapis/webstorage/WebStorageModule.kt
@@ -10,6 +10,7 @@ import com.facebook.react.bridge.ReactMethod
 class WebStorageModule(context: ReactApplicationContext) : ReactContextBaseJavaModule(context) {
 
     companion object {
+        const val IS_TURBO_MODULE = false
         const val NAME = "RNWWebStorage"
     }