fix(metro-config): handle apps in nested folders (#2995)

microsoft · Mar 11, 2024 · 3f48b88 · 3f48b88
1 parent 8033573
commit 3f48b88
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/.changeset/twenty-gorillas-sneeze.md b/.changeset/twenty-gorillas-sneeze.md
@@ -0,0 +1,5 @@
+---
+"@rnx-kit/metro-config": patch
+---
+
+Handle apps in nested folders
diff --git a/packages/metro-config/src/defaultConfig.js b/packages/metro-config/src/defaultConfig.js
@@ -1,7 +1,7 @@
 // @ts-check
+const { findUp } = require("@rnx-kit/tools-node/path");
 const { requireModuleFromMetro } = require("@rnx-kit/tools-react-native/metro");
 const fs = require("fs");
-const path = require("path");
 
 /**
  * @typedef {import("metro-config").MetroConfig} MetroConfig;
@@ -104,10 +104,14 @@ function outOfTreePlatformResolver(implementations, projectRoot) {
  * @returns {MetroConfig[]}
  */
 function getDefaultConfig(projectRoot) {
-  try {
-    const pkgJson = path.join(projectRoot, "package.json");
-    const manifest = fs.readFileSync(pkgJson, { encoding: "utf-8" });
-    if (manifest.includes("@react-native/metro-config")) {
+  const pkgJson = findUp("package.json", { startDir: projectRoot });
+  if (!pkgJson) {
+    return [];
+  }
+
+  const manifest = fs.readFileSync(pkgJson, { encoding: "utf-8" });
+  if (manifest.includes("@react-native/metro-config")) {
+    try {
       const metroConfigPath = require.resolve("@react-native/metro-config", {
         paths: [projectRoot],
       });
@@ -129,10 +133,11 @@ function getDefaultConfig(projectRoot) {
       };
 
       return [defaultConfig];
+    } catch (_) {
+      // Ignore
     }
-  } catch (_) {
-    // Ignore
   }
+
   return [];
 }