Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metro-resolver-symlinks): experimental option to retry resolving from disk #2044

Merged
merged 6 commits into from
Nov 30, 2022

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Nov 21, 2022

Description

Add an experimental option for retrying module resolution from disk if not found in Haste map.

A proper solution would be to implement lazy crawling upstream but that may take some time. In the meantime, this is a workaround that works and doesn't cause too much pollution.

Test plan

This has been tested by a few teams internally.

@tido64 tido64 added the feature: metro This is related to Metro label Nov 21, 2022
@tido64
Copy link
Member Author

tido64 commented Nov 21, 2022

@tido64 tido64 marked this pull request as ready for review November 24, 2022 10:50
Copy link
Contributor

@afoxman afoxman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So happy to see this idea taking off! I have a few questions/comments. Once we've finalized here, and are using the official @rnx-kit version internally, we should look at publishing the numbers we're seeing, even high-level metrics like "CI builds ran 25% faster (12 mins)".

@tido64
Copy link
Member Author

tido64 commented Nov 30, 2022

So happy to see this idea taking off! I have a few questions/comments. Once we've finalized here, and are using the official @rnx-kit version internally, we should look at publishing the numbers we're seeing, even high-level metrics like "CI builds ran 25% faster (12 mins)".

This is definitely something worth writing home about. Vincent's testing saw build time go from 4 min to 27 sec for a single package on a beefy computer.

@tido64 tido64 force-pushed the tido/experiments/metro-disable-haste branch from ce91723 to 2578048 Compare November 30, 2022 10:37
@tido64 tido64 merged commit 80e6557 into microsoft:main Nov 30, 2022
@tido64 tido64 deleted the tido/experiments/metro-disable-haste branch December 2, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: metro This is related to Metro
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants