-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metro-resolver-symlinks): experimental option to retry resolving from disk #2044
feat(metro-resolver-symlinks): experimental option to retry resolving from disk #2044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So happy to see this idea taking off! I have a few questions/comments. Once we've finalized here, and are using the official @rnx-kit
version internally, we should look at publishing the numbers we're seeing, even high-level metrics like "CI builds ran 25% faster (12 mins)".
This is definitely something worth writing home about. Vincent's testing saw build time go from 4 min to 27 sec for a single package on a beefy computer. |
ce91723
to
2578048
Compare
Description
Add an experimental option for retrying module resolution from disk if not found in Haste map.
A proper solution would be to implement lazy crawling upstream but that may take some time. In the meantime, this is a workaround that works and doesn't cause too much pollution.
Test plan
This has been tested by a few teams internally.