Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(align-deps): allow version range subsets #3184

Merged
merged 2 commits into from
Jun 7, 2024
Merged

feat(align-deps): allow version range subsets #3184

merged 2 commits into from
Jun 7, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jun 6, 2024

Description

Allow exact and version range subsets with --diff-mode allow-subset.

Resolves #2983
Resolves #2984

Test plan

n/a

@tido64 tido64 requested a review from acoates-ms June 6, 2024 13:16
@github-actions github-actions bot added feature: align-deps This is related to align-deps feature: cli This is related to CLI labels Jun 6, 2024
JasonVMo
JasonVMo approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@JasonVMo JasonVMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good change. One question is whether this will lead to more duplicate packages within the repo and whether we need to do something to counteract that.

@tido64
Copy link
Member Author

tido64 commented Jun 7, 2024

Looks like a good change. One question is whether this will lead to more duplicate packages within the repo and whether we need to do something to counteract that.

It's more likely that dupes will be introduced. I've added a warning label in the docs.

@tido64 tido64 enabled auto-merge (squash) June 7, 2024 07:28
@tido64 tido64 merged commit 9a2775d into main Jun 7, 2024
10 checks passed
@tido64 tido64 deleted the tido/align-deps/allow-exact-version branch June 7, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonVMo JasonVMo JasonVMo approved these changes

@acoates-ms acoates-ms Awaiting requested review from acoates-ms acoates-ms is a code owner

@kelset kelset Awaiting requested review from kelset

Assignees
No one assigned
Labels
feature: align-deps This is related to align-deps feature: cli This is related to CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

align-deps: new flag to not throw an error for exact dependencies that are within bounds
2 participants
@tido64 @JasonVMo