Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-native-host): override feature flags for bridgeless mode #3196

Merged
merged 2 commits into from
Jun 19, 2024
Merged

fix(react-native-host): override feature flags for bridgeless mode #3196

merged 2 commits into from
Jun 19, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jun 19, 2024

Description

Override feature flags for bridgeless mode.

Test plan

This needs to be tested in RNTA:

npm run set-react-version 0.74 -- --core-only
yarn clean
yarn

# Manually apply changes under node_modules/@rnx-kit/react-native-host/

cd example
RCT_NEW_ARCH_ENABLED=1 pod install --project-directory=ios
yarn ios

# In a separate terminal
yarn start

Screenshots

Simulator Screenshot - iPhone 15 Pro - 2024-06-19 at 11 47 40

@github-actions github-actions bot added the feature: sdk This is related to 1RN SDK label Jun 19, 2024
@tido64 tido64 merged commit 99bcb24 into main Jun 19, 2024
10 checks passed
@tido64 tido64 deleted the tido/rn-host/override-feature-flags branch June 19, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

@JasonVMo JasonVMo JasonVMo approved these changes

@acoates-ms acoates-ms Awaiting requested review from acoates-ms acoates-ms is a code owner

Assignees
No one assigned
Labels
feature: sdk This is related to 1RN SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tido64 @Saadnajmi @JasonVMo