Merge pull request #4667 from aramissennyeydd/sennyeya/fix-cobuild-sy…

…mbols [console-timeline] update: show only cobuild build steps in the build timeline
microsoft · May 1, 2024 · 0c41a82 · 0c41a82
2 parents 7a6b721 + 030c7a7
commit 0c41a82
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/common/changes/@microsoft/rush/sennyeya-fix-cobuild-symbols_2024-04-29-16-45.json b/common/changes/@microsoft/rush/sennyeya-fix-cobuild-symbols_2024-04-29-16-45.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Timeline view will now only show terminal build statuses as cobuilt, all other statuses will reflect their original icons.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush"
+}
diff --git a/libraries/rush-lib/src/logic/operations/ConsoleTimelinePlugin.ts b/libraries/rush-lib/src/logic/operations/ConsoleTimelinePlugin.ts
@@ -89,6 +89,13 @@ const TIMELINE_CHART_SYMBOLS: Record<OperationStatus, string> = {
   [OperationStatus.NoOp]: '%'
 };
 
+const COBUILD_REPORTABLE_STATUSES: Set<OperationStatus> = new Set([
+  OperationStatus.Success,
+  OperationStatus.SuccessWithWarning,
+  OperationStatus.Failure,
+  OperationStatus.Blocked
+]);
+
 /**
  * Timeline - colorizer for each operation status
  */
@@ -232,7 +239,7 @@ export function _printTimeline({ terminal, result, cobuildConfiguration }: IPrin
 
   function getChartSymbol(record: ITimelineRecord): string {
     const { isExecuteByOtherCobuildRunner, status } = record;
-    if (isExecuteByOtherCobuildRunner) {
+    if (isExecuteByOtherCobuildRunner && COBUILD_REPORTABLE_STATUSES.has(status)) {
       hasCobuildSymbol = true;
       return 'C';
     }