[rush] update: show only cobuild build steps in the build timeline #4667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramissennyeydd
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
|
Can you include example before and after output? |
iclanton
approved these changes
Apr 30, 2024
|
@iclanton It's a little hard to show across both terminals, so adding screenshots instead of text output. Before:
After:
|
octogonz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The timeline can get confusing when cobuilds have a lot of cache hits, all machines report the status as skipped or restored from cache but they show up as cobuilds in the timeline. This makes it a little harder to debug and understand if a project is being built on a separate machine or just being restored from cache on a separate machine. This PR makes it so that only terminal build statuses are reflected as cobuilds in the timeline.
Details
This forces cobuilds to only show for terminal build states (success, success w/ warning, error and blocked), all other states show the original icons. We could flip this to just have cache restores show the original icon, but I think the value in flipping it is stronger for taking a quick look at the timeline and understanding where actionable work has been split up - non build steps clutter that view.
How it was tested
Tested locally using the
repoproject for cobuild testing. Verified that terminal build statuses show up asCand cache restores show up as%.Impacted documentation